-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp #6330
Conversation
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@albertnetymk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 50 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks for the review. /integrate |
Going to push as commit 02f7900.
Your commit was automatically rebased without conflicts. |
@albertnetymk Pushed as commit 02f7900. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
/backport jdk17u-dev |
@rvansa Could not automatically backport
Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk17u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.
Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk17u-dev with the title Below you can find a suggestion for the pull request body:
|
This PR consists of two commits: the first commit is generated using
clang-tidy --fix src/hotspot/share/gc/g1/g1CollectedHeap.hpp -checks=modernize-use-override -p build/linux-x64-debug
, and the second commit fixes some indentation issues.Test: build
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6330/head:pull/6330
$ git checkout pull/6330
Update a local copy of the PR:
$ git checkout pull/6330
$ git pull https://git.openjdk.java.net/jdk pull/6330/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6330
View PR using the GUI difftool:
$ git pr show -t 6330
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6330.diff