Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges #6335

Closed
wants to merge 1 commit into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Nov 10, 2021

This changes the specification of DateTimeFormatterBuilder.appendFraction to more clearly specify that the formatter will throw an exception if you attempt to print a value outside of the value range of the given field. Changes suggested by @jodastephen in #6188.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6335/head:pull/6335
$ git checkout pull/6335

Update a local copy of the PR:
$ git checkout pull/6335
$ git pull https://git.openjdk.java.net/jdk pull/6335/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6335

View PR using the GUI difftool:
$ git pr show -t 6335

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6335.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 10, 2021
@openjdk
Copy link

openjdk bot commented Nov 10, 2021

@cl4es The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Nov 10, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 10, 2021

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges

Reviewed-by: rriggs, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • ce3ed65: 8273154: Provide a JavadocTester method for non-overlapping, unordered output matching
  • f561d3c: 8276864: Update boot JDKs to 17.0.1 in GHA
  • 38ec3a1: 8276672: Cannot build hsdis on WSL

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 10, 2021
@cl4es
Copy link
Member Author

cl4es commented Nov 11, 2021

Thanks Roger and Naoto. CSR has been filed and approved.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 11, 2021

Going to push as commit 0ca0acf.
Since your change was applied there have been 23 commits pushed to the master branch:

  • b0d7a9d: 8276994: java/nio/channels/Channels/TransferTo.java leaves multi-GB files in /tmp
  • 8aae88b: 8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out"
  • 6f35eed: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails
  • 5e98f99: 8276800: Fix table headers in NumericShaper.html
  • 2ca4ff8: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI
  • c29cab8: 8276112: Inconsistent scalar replacement debug info at safepoints
  • aea0967: 8275854: C2: assert(stride_con != 0) failed: missed some peephole opt
  • 9862cd0: 8275786: New javadoc option to add script files to generated documentation
  • 7a140af: 8276546: [IR Framework] Whitelist and ignore CompileThreshold
  • 91bb0d6: 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/55b36c6f3bb7eb066daaf41f9eba46633afedf08...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 11, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 11, 2021
@openjdk
Copy link

openjdk bot commented Nov 11, 2021

@cl4es Pushed as commit 0ca0acf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
3 participants