New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges #6335
Conversation
|
@cl4es This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Thanks Roger and Naoto. CSR has been filed and approved. /integrate |
Going to push as commit 0ca0acf.
Your commit was automatically rebased without conflicts. |
This changes the specification of
DateTimeFormatterBuilder.appendFraction
to more clearly specify that the formatter will throw an exception if you attempt to print a value outside of the value range of the given field. Changes suggested by @jodastephen in #6188.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6335/head:pull/6335
$ git checkout pull/6335
Update a local copy of the PR:
$ git checkout pull/6335
$ git pull https://git.openjdk.java.net/jdk pull/6335/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6335
View PR using the GUI difftool:
$ git pr show -t 6335
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6335.diff