Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out" #6351

Closed
wants to merge 1 commit into from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Nov 11, 2021

test/jdk/java/nio/channels/SocketChannel/AdaptorStreams.java tests SocketChannel's socket adaptor. Two of tests, testTimedRead1 and testTimedRead2 have relatively short timeouts which can cause the test to fail if the VM is paused or the machine is hung/overloaded for more than a few seconds. I've changed the timeout used by the two tests to 60s. This change does not impact the duration of the test because the reads do not timeout.

In passing, I've changed testTimedRead3 to use a timeout of 500ms, it is expected to throw SocketTimeoutException, and replaced setSoTimeout(60*1000) with setSoTimeout(60_000) in several other tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6351/head:pull/6351
$ git checkout pull/6351

Update a local copy of the PR:
$ git checkout pull/6351
$ git pull https://git.openjdk.java.net/jdk pull/6351/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6351

View PR using the GUI difftool:
$ git pr show -t 6351

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6351.diff

@AlanBateman AlanBateman marked this pull request as draft Nov 11, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 11, 2021

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2021

@AlanBateman The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio label Nov 11, 2021
@AlanBateman AlanBateman marked this pull request as ready for review Nov 11, 2021
@openjdk openjdk bot added the rfr label Nov 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 11, 2021

Webrevs

dfuch
dfuch approved these changes Nov 11, 2021
Copy link
Member

@dfuch dfuch left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2021

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out"

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 6f35eed: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails
  • 5e98f99: 8276800: Fix table headers in NumericShaper.html
  • 2ca4ff8: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 11, 2021
@AlanBateman
Copy link
Contributor Author

@AlanBateman AlanBateman commented Nov 11, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2021

Going to push as commit 8aae88b.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 6f35eed: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails
  • 5e98f99: 8276800: Fix table headers in NumericShaper.html
  • 2ca4ff8: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2021

@AlanBateman Pushed as commit 8aae88b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated nio
2 participants