New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277012: Use blessed modifier order in src/utils #6354
Conversation
/label hotspot build |
|
@magicus The |
@magicus This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
Going to push as commit c4b4432.
Your commit was automatically rebased without conflicts. |
I ran bin/blessed-modifier-order.sh on source code in src/utils. This scripts verifies that modifiers are in the "blessed" order, and fixes it otherwise. I have manually checked the changes made by the script to make sure they are sound.
There are no clear ownership of this code, but I believe it's kind of hotspot-related.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6354/head:pull/6354
$ git checkout pull/6354
Update a local copy of the PR:
$ git checkout pull/6354
$ git pull https://git.openjdk.java.net/jdk pull/6354/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6354
View PR using the GUI difftool:
$ git pr show -t 6354
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6354.diff