8276921: G1: Remove redundant failed evacuation regions calculation in RemoveSelfForwardPtrHRClosure

[Hamlin-Li]

This is a minor optimization.
We already have the number of failed evacuation region numbers, there is no need to calculate it on fly, at least in product code, so make it debug only, and add assert to verify the result.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8276921: G1: Remove redundant failed evacuation regions calculation in RemoveSelfForwardPtrHRClosure

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6362/head:pull/6362
$ git checkout pull/6362

Update a local copy of the PR:
$ git checkout pull/6362
$ git pull https://git.openjdk.java.net/jdk pull/6362/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6362

View PR using the GUI difftool:
$ git pr show -t 6362

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6362.diff

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7f0f14a7)
• 00: Full (0637b050)

[albertnetymk]

I think _num_failed_regions can be dropped completely; it's used for verification only. ~RemoveSelfForwardPtrsTask can go as well as a cascading effect.

[Hamlin-Li]

Thanks Albert, I agree.

[tschatzl]

Also good.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276921: G1: Remove redundant failed evacuation regions calculation in RemoveSelfForwardPtrHRClosure

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• ca2efb7: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
• 296780c: 8276983: Small fixes to DumpAllocStat::print_stats
• 8c5f030: 8276453: Undefined behavior in C1 LIR_OprDesc causes SEGV in fastdebug build
• 176d21d: 8276824: refactor Thread::is_JavaThread_protected
• 74f3e69: 8277071: [BACKOUT] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"
• b85500e: 8276123: ZipFile::getEntry will not return a file entry when there is a directory entry of the same name within a Zip File
• 0d2980c: 8258192: Obsolete the CriticalJNINatives flag
• 5a2452c: 8274835: Remove unnecessary castings in java.base
• 3b2585c: 8276658: Clean up JNI local handles code
• aeba653: 8276743: Make openjdk build Zip Archive generation "reproducible"
• ... and 40 more: https://git.openjdk.java.net/jdk/compare/e91e9d853272ea8f5ce490f2f0c971fd40795d74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[Hamlin-Li]

Thanks @tschatzl @albertnetymk for your reviews.

/integrate

[openjdk]

Going to push as commit b231f5b.
Since your change was applied there have been 50 commits pushed to the master branch:

• ca2efb7: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
• 296780c: 8276983: Small fixes to DumpAllocStat::print_stats
• 8c5f030: 8276453: Undefined behavior in C1 LIR_OprDesc causes SEGV in fastdebug build
• 176d21d: 8276824: refactor Thread::is_JavaThread_protected
• 74f3e69: 8277071: [BACKOUT] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"
• b85500e: 8276123: ZipFile::getEntry will not return a file entry when there is a directory entry of the same name within a Zip File
• 0d2980c: 8258192: Obsolete the CriticalJNINatives flag
• 5a2452c: 8274835: Remove unnecessary castings in java.base
• 3b2585c: 8276658: Clean up JNI local handles code
• aeba653: 8276743: Make openjdk build Zip Archive generation "reproducible"
• ... and 40 more: https://git.openjdk.java.net/jdk/compare/e91e9d853272ea8f5ce490f2f0c971fd40795d74...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit b231f5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.