Skip to content

8277059: Use blessed modifier order in java.xml #6369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Nov 12, 2021

I ran bin/blessed-modifier-order.sh on source code in java.xml and java.xml.crypto. This scripts verifies that modifiers are in the "blessed" order, and fixes it otherwise. I have manually checked the changes made by the script to make sure they are sound.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6369/head:pull/6369
$ git checkout pull/6369

Update a local copy of the PR:
$ git checkout pull/6369
$ git pull https://git.openjdk.java.net/jdk pull/6369/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6369

View PR using the GUI difftool:
$ git pr show -t 6369

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6369.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2021

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2021
@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@magicus The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Nov 12, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2021

Webrevs

@JoeWang-Java
Copy link
Member

JoeWang-Java commented Nov 12, 2021

Thanks, Magnus. However, we've discussed the issue for sources from the 3rd party, and we'd like to keep it that way to facilitate any future merges. Refer to JDK-8264019 / #3091.

@magicus
Copy link
Member Author

magicus commented Nov 15, 2021

I understand. I just checked the git history and saw that there were other code hygiene changes. I'll close this issue then.

@magicus magicus closed this Nov 15, 2021
@magicus magicus deleted the xml-blessed-order branch December 3, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants