Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8277071 [BACKOUT] JDK-8276743 Make openjdk build Zip Archive generation "reproducible" #6370

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Nov 12, 2021

This reverts commit aeba653.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277071: [BACKOUT] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6370/head:pull/6370
$ git checkout pull/6370

Update a local copy of the PR:
$ git checkout pull/6370
$ git pull https://git.openjdk.java.net/jdk pull/6370/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6370

View PR using the GUI difftool:
$ git pr show -t 6370

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6370.diff

@dcubed-ojdk
Copy link
Member Author

/label add build
/label add hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the build build-dev@openjdk.org label Nov 12, 2021
@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@dcubed-ojdk
The build label was successfully added.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 12, 2021
@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review November 12, 2021 18:33
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277071: [BACKOUT] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 12, 2021
@dcubed-ojdk
Copy link
Member Author

@erikj79 - Thanks for the fast review!

/integrate

@openjdk
Copy link

openjdk bot commented Nov 12, 2021

Going to push as commit 74f3e69.

@openjdk openjdk bot closed this Nov 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 12, 2021
@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@dcubed-ojdk Pushed as commit 74f3e69.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8277071 branch November 12, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants