Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276976: Rename LIR_OprDesc to LIR_Opr #6377

Closed
wants to merge 1 commit into from

Conversation

caoman
Copy link
Contributor

@caoman caoman commented Nov 12, 2021

Hi all,

Can I have reviews for this mechanical renaming change as a follow up to https://bugs.openjdk.java.net/browse/JDK-8276453?


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Contributors

  • Chuck Rasbold <rasbold@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6377/head:pull/6377
$ git checkout pull/6377

Update a local copy of the PR:
$ git checkout pull/6377
$ git pull https://git.openjdk.java.net/jdk pull/6377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6377

View PR using the GUI difftool:
$ git pr show -t 6377

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6377.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2021

👋 Welcome back manc! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@caoman
Copy link
Contributor Author

caoman commented Nov 12, 2021

/contributor add rasbold

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2021
@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@caoman
Contributor Chuck Rasbold <rasbold@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@caoman The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 12, 2021
@caoman
Copy link
Contributor Author

caoman commented Nov 12, 2021

/label remove hotspot

@caoman
Copy link
Contributor Author

caoman commented Nov 12, 2021

/label add hotspot-compiler

@openjdk openjdk bot removed the hotspot hotspot-dev@openjdk.org label Nov 12, 2021
@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@caoman
The hotspot label was successfully removed.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 12, 2021
@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@caoman
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 12, 2021

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

@openjdk
Copy link

openjdk bot commented Nov 18, 2021

@caoman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276976: Rename LIR_OprDesc to LIR_Opr

Co-authored-by: Chuck Rasbold <rasbold@openjdk.org>
Reviewed-by: thartmann, iveresov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

  • 89b125f: 8275527: Refactor forward pointer access
  • 36bd4a3: 8277404: Test VMDeprecatedOptions.java failing with Unable to create shared archive file
  • 57eb864: 8276927: [PPC64] Port shenandoahgc to linux on ppc64le
  • 8db0c36: 8277414: ProblemList runtime/CommandLine/VMDeprecatedOptions.java on windows-x64
  • 03473b4: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor
  • ce0f00f: 8276093: Improve naming in closures to iterate over card sets
  • 5d249c4: 8275071: [macos] A11y cursor gets stuck when combobox is closed
  • 354a34e: 8277336: Improve CollectedHeap::safepoint_workers comments
  • 276bfcd: 8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058
  • d93b238: 8277180: Intrinsify recursive ObjectMonitor locking for C2 x64 and A64
  • ... and 64 more: https://git.openjdk.java.net/jdk/compare/8c5f03049196e66a4f8411bdd853b287134e7ce5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2021
Copy link
Contributor

@veresov veresov left a comment

Looks good.

@caoman
Copy link
Contributor Author

caoman commented Nov 18, 2021

Thank you for the reviews

@caoman
Copy link
Contributor Author

caoman commented Nov 18, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 18, 2021

Going to push as commit 839033b.
Since your change was applied there have been 74 commits pushed to the master branch:

  • 89b125f: 8275527: Refactor forward pointer access
  • 36bd4a3: 8277404: Test VMDeprecatedOptions.java failing with Unable to create shared archive file
  • 57eb864: 8276927: [PPC64] Port shenandoahgc to linux on ppc64le
  • 8db0c36: 8277414: ProblemList runtime/CommandLine/VMDeprecatedOptions.java on windows-x64
  • 03473b4: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor
  • ce0f00f: 8276093: Improve naming in closures to iterate over card sets
  • 5d249c4: 8275071: [macos] A11y cursor gets stuck when combobox is closed
  • 354a34e: 8277336: Improve CollectedHeap::safepoint_workers comments
  • 276bfcd: 8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058
  • d93b238: 8277180: Intrinsify recursive ObjectMonitor locking for C2 x64 and A64
  • ... and 64 more: https://git.openjdk.java.net/jdk/compare/8c5f03049196e66a4f8411bdd853b287134e7ce5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2021
@openjdk
Copy link

openjdk bot commented Nov 18, 2021

@caoman Pushed as commit 839033b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@caoman caoman deleted the JDK8276976 branch Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants