Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254704: Add missing @since tag to BodyPublishers::concat #638

Closed
wants to merge 1 commit into from

Conversation

@dfuch
Copy link
Member

@dfuch dfuch commented Oct 13, 2020

Please review a trivial change that adds a missing @since 16 tag to the API documentation of the new BodyPublishers::concat method. I missed that in my changes that was integrated yesterday - and that was unfortunately missed in the review and CSR as well.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (5/9 running) ✔️ (9/9 passed)

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/638/head:pull/638
$ git checkout pull/638

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 13, 2020

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2020

@dfuch The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net label Oct 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2020

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254704: Add missing @since tag to BodyPublishers::concat

Reviewed-by: chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 3fb2e82: 8254627: Cleanup {Abstract,Single,Split}IndexWriter classes
  • 02d9c29: 8254672: ZGC: ZParallelOopsDo/ZSerialWeakOopsDo should use atomic load/store

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 13, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 13, 2020

Webrevs

@dfuch
Copy link
Member Author

@dfuch dfuch commented Oct 13, 2020

/integrate

@openjdk openjdk bot closed this Oct 13, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2020

@dfuch Since your change was applied there have been 2 commits pushed to the master branch:

  • 3fb2e82: 8254627: Cleanup {Abstract,Single,Split}IndexWriter classes
  • 02d9c29: 8254672: ZGC: ZParallelOopsDo/ZSerialWeakOopsDo should use atomic load/store

Your commit was automatically rebased without conflicts.

Pushed as commit 6ed4c89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dfuch dfuch deleted the concat-JDK-8254704 branch Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants