8277102: Dubious PrintCompilation output #6386

kelthuzadx · 2021-11-15T11:09:35Z

The output of PrintCompilation is ill-formed:

     22 1 3 java.lang.Object::<init> (1 bytes)
     25 2 3 java.lang.String::hashCode (60 bytes)
     25 3 3 java.lang.String::coder (15 bytes)
     27 4 3 Reduced::foo (12 bytes)
     27 5 3 java.lang.Boolean::valueOf (14 bytes)
     27 6 3 java.lang.Boolean::hashCode (8 bytes)
     27 8 4 Reduced::foo (12 bytes)
     27 7 2 java.lang.Boolean::hashCode (14 bytes)
   4 3 Reduced::foo (12 bytes) made not entrant
     29 9 % 3 Reduced::main @ 4 (33 bytes)
     29 10 3 Reduced::main (33 bytes)
     29 11 % 4 Reduced::main @ 4 (33 bytes)
   9 % 3 Reduced::main @ 4 (33 bytes) made not entrant
  11 % 4 Reduced::main @ 4 (33 bytes) made not entrant

This seems related to JDK-8272586, which print timestamp optionally. As #5446 mentioned, printing timestamp would break DisassembleCodeBlobTest.java since it expects disassembling a given nmethod twice to produce the same result. Maybe we should fix DisassembleCodeBlobTest.java.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8277102: Dubious PrintCompilation output

Reviewers

Tobias Hartmann (@TobiHartmann - Reviewer)
Doug Simon (@dougxc - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6386/head:pull/6386
$ git checkout pull/6386

Update a local copy of the PR:
$ git checkout pull/6386
$ git pull https://git.openjdk.java.net/jdk pull/6386/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6386

View PR using the GUI difftool:
$ git pr show -t 6386

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6386.diff

bridgekeeper · 2021-11-15T11:11:01Z

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-11-15T11:13:51Z

@kelthuzadx The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-11-16T02:22:45Z

Webrevs

00: Full (e65e7495)

TobiHartmann · 2021-11-18T09:54:25Z

test/hotspot/jtreg/compiler/jvmci/compilerToVM/DisassembleCodeBlobTest.java

+        // <empty-line>
+        // Compiled method (c2)     310  463       4       compiler.jvmci.compilerToVM.CompileCodeTestCase$Dummy::staticMethod (1 bytes)
+        for (int i = 2; i < str2Lines.length; i++) {
+            Asserts.assertEQ(str2Lines[i], str3Lines[i],


Splitting the entire string by lines seems like a bit of an overhead. What about something like that (not tested)?

int idx = str2.indexOf(System.lineSeparator()); idx = str2.indexOf(System.lineSeparator(), idx + 1); str2 = str2.substring(idx + 1);

Doing it by lines will actually provide a more focused error message if there's a problem and I cannot image the overhead matters for a test like this.

Right, good point.

TobiHartmann

Looks reasonable to me but a second review (@dougxc?) would be good.

TobiHartmann · 2021-11-18T09:55:17Z

/reviewers 2

openjdk · 2021-11-18T09:56:06Z

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277102: Dubious PrintCompilation output

Reviewed-by: thartmann, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

db55f92: 8277343: dynamicArchive/SharedArchiveFileOption.java failed: '-XX:+RecordDynamicDumpInfo is unsupported when a dynamic CDS archive is specified in -XX:SharedArchiveFile:' missing
2f4b540: 8276314: [JVMCI] check alignment of call displacement during code installation
9160743: 8276058: Some swing test fails on specific CI macos system
8193800: 8274179: AArch64: Support SVE operations with encodable immediates
b8453eb: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales
231fb61: 8276970: Default charset for PrintWriter that wraps PrintStream
29e552c: 8272358: Some tests may fail when executed with other locales than the US
ce4471f: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64
45a60db: 8277045: G1: Remove unnecessary set_concurrency call in G1ConcurrentMark::weak_refs_work
6bb0462: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
... and 45 more: https://git.openjdk.java.net/jdk/compare/ca2efb73f59112d9be2ec29db405deb4c58dd435...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2021-11-18T09:56:29Z

@TobiHartmann
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

kelthuzadx · 2021-11-19T02:03:46Z

Thanks @TobiHartmann and @dougxc for reviews！

kelthuzadx · 2021-11-19T02:04:06Z

/integrate

openjdk · 2021-11-19T02:04:54Z

Going to push as commit 2f0bde1.
Since your change was applied there have been 73 commits pushed to the master branch:

839033b: 8276976: Rename LIR_OprDesc to LIR_Opr
89b125f: 8275527: Refactor forward pointer access
36bd4a3: 8277404: Test VMDeprecatedOptions.java failing with Unable to create shared archive file
57eb864: 8276927: [PPC64] Port shenandoahgc to linux on ppc64le
8db0c36: 8277414: ProblemList runtime/CommandLine/VMDeprecatedOptions.java on windows-x64
03473b4: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor
ce0f00f: 8276093: Improve naming in closures to iterate over card sets
5d249c4: 8275071: [macos] A11y cursor gets stuck when combobox is closed
354a34e: 8277336: Improve CollectedHeap::safepoint_workers comments
276bfcd: 8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058
... and 63 more: https://git.openjdk.java.net/jdk/compare/ca2efb73f59112d9be2ec29db405deb4c58dd435...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-11-19T02:05:09Z

@kelthuzadx Pushed as commit 2f0bde1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the hotspot-compiler label Nov 15, 2021

8277102 Dubious PrintCompilation output

e65e749

kelthuzadx force-pushed the illformed_printtcompilation branch from fed7e1c to e65e749 Compare Nov 16, 2021

openjdk bot added the rfr label Nov 16, 2021

TobiHartmann reviewed Nov 18, 2021

View changes

TobiHartmann approved these changes Nov 18, 2021

View changes

openjdk bot added the ready label Nov 18, 2021

openjdk bot removed the ready label Nov 18, 2021

dougxc approved these changes Nov 18, 2021

View changes

openjdk bot added the ready label Nov 18, 2021

openjdk bot closed this Nov 19, 2021

openjdk bot added integrated and removed ready rfr labels Nov 19, 2021

kelthuzadx deleted the illformed_printtcompilation branch Nov 19, 2021

openjdk / jdk Public

8277102: Dubious PrintCompilation output #6386

8277102: Dubious PrintCompilation output #6386

kelthuzadx commented Nov 15, 2021 •

edited by openjdk[bot] bot

bridgekeeper bot commented Nov 15, 2021

openjdk bot commented Nov 15, 2021

mlbridge bot commented Nov 16, 2021

TobiHartmann Nov 18, 2021

dougxc Nov 18, 2021

TobiHartmann Nov 18, 2021

TobiHartmann left a comment

TobiHartmann commented Nov 18, 2021

openjdk bot commented Nov 18, 2021 •

edited

openjdk bot commented Nov 18, 2021

kelthuzadx commented Nov 19, 2021

kelthuzadx commented Nov 19, 2021

openjdk bot commented Nov 19, 2021

openjdk bot commented Nov 19, 2021

openjdk / jdk Public

8277102: Dubious PrintCompilation output #6386

8277102: Dubious PrintCompilation output #6386

Conversation

kelthuzadx commented Nov 15, 2021 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Nov 15, 2021

openjdk bot commented Nov 15, 2021

mlbridge bot commented Nov 16, 2021

Webrevs

TobiHartmann Nov 18, 2021

Choose a reason for hiding this comment

dougxc Nov 18, 2021

Choose a reason for hiding this comment

TobiHartmann Nov 18, 2021

Choose a reason for hiding this comment

TobiHartmann left a comment

TobiHartmann commented Nov 18, 2021

openjdk bot commented Nov 18, 2021 • edited

openjdk bot commented Nov 18, 2021

kelthuzadx commented Nov 19, 2021

kelthuzadx commented Nov 19, 2021

openjdk bot commented Nov 19, 2021

openjdk bot commented Nov 19, 2021

kelthuzadx commented Nov 15, 2021 •

edited by openjdk[bot] bot

openjdk bot commented Nov 18, 2021 •

edited