Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277119: Add asserts in GenericTaskQueueSet methods #6388

Closed

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Nov 15, 2021

Some methods in GenericTaskQueueSet lack of assert, which is not friendly to debug/troubleshooting.
This is to add necessary asserts.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277119: Add asserts in GenericTaskQueueSet methods

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6388/head:pull/6388
$ git checkout pull/6388

Update a local copy of the PR:
$ git checkout pull/6388
$ git pull https://git.openjdk.java.net/jdk pull/6388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6388

View PR using the GUI difftool:
$ git pr show -t 6388

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6388.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 15, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 15, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

These look good to me.

May I ask if there is anything in particular you're looking into in this area? I have also been doing some investigation there and particularly wrt to the stealing and task termination found a few significant things to improve.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277119: Add asserts in GenericTaskQueueSet methods

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

  • 1830b8d: 8275056: Virtualize G1CardSet containers over heap region
  • fe45835: 8274856: Failing jpackage tests with fastdebug/release build
  • 9046077: 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional
  • 7fc344d: 8277028: Use service type documentation as fallback for @provides
  • 35a831d: 8272170: Missing memory barrier when checking active state for regions
  • 02f7900: 8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp
  • fdcd16a: 8277048: Tiny improvements to the specification text for java.util.Properties.load
  • b231f5b: 8276921: G1: Remove redundant failed evacuation regions calculation in RemoveSelfForwardPtrHRClosure
  • ca2efb7: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
  • 296780c: 8276983: Small fixes to DumpAllocStat::print_stats
  • ... and 48 more: https://git.openjdk.java.net/jdk/compare/e91e9d853272ea8f5ce490f2f0c971fd40795d74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 15, 2021
@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Nov 16, 2021

May I ask if there is anything in particular you're looking into in this area? I have also been doing some investigation there and particularly wrt to the stealing and task termination found a few significant things to improve.

Thanks for sharing and asking.
Not exactly, I'm working the prototype of https://bugs.openjdk.java.net/browse/JDK-8256265 which is to improve the parallelism of evac failure process. I'm using taskqueue to implement the balance among threads, it took me a while to fix a crash issue which finally prove to be the wrong usage of taskqueue, and I think it would cost me less time if the asserts already existed there.
Please kindly let me know if you think I can help on the things related to "stealing and task termination". :)

@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Nov 16, 2021

I think this one is trivial, am I good to push?

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Nov 16, 2021

Yes I'm fine for this to be pushed with one reviewer. Go ahead to integrate.

@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Nov 16, 2021

Thanks Thomas for your confirmation and review.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

Going to push as commit 7906eb0.
Since your change was applied there have been 73 commits pushed to the master branch:

  • 1c45c8a: 8274757: Cleanup unnecessary calls to Throwable.initCause() in java.management module
  • c06df25: 8274662: Replace 'while' cycles with iterator with enhanced-for in jdk.hotspot.agent
  • 9629627: 8274163: Use String.equals instead of String.compareTo in jdk.jcmd
  • 0bc2683: 8274190: Use String.equals instead of String.compareTo in jdk.internal.jvmstat
  • a9cb8bd: 8274168: Avoid String.compareTo == 0 to check String equality in java.management
  • 20f3872: 8274261: Use enhanced-for instead of plain 'for' in jdk.jcmd
  • b8d33a2: 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes
  • 1d79cfd: 8276229: Stop allowing implicit updates in G1BlockOffsetTable
  • 7719a74: 8277172: Remove stray comment mentioning instr_size_for_decode_klass_not_null on x64
  • e436200: 8008243: Zero: Implement fast bytecodes
  • ... and 63 more: https://git.openjdk.java.net/jdk/compare/e91e9d853272ea8f5ce490f2f0c971fd40795d74...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

@Hamlin-Li Pushed as commit 7906eb0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the add-assert-in-GenericTaskQueueSet branch Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
2 participants