8276665: ObjectInputStream.GetField.get(name, object) should throw ClassNotFoundException

[RogerRiggs]

The ObjectInputStream.GetField.get(String name, Object val) method is returning null instead of throwing an exception when the class of the object is not found. The caller is not able to correctly handle the case where the class is not found. The signature of GetField.get(name, val) should have a throws ClassNotFoundException and a ClassNotFoundException exception should be thrown.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8276665: ObjectInputStream.GetField.get(name, object) should throw ClassNotFoundException

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Lance Andersen (@LanceAndersen - Reviewer)
• Stuart Marks (@stuart-marks - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6393/head:pull/6393
$ git checkout pull/6393

Update a local copy of the PR:
$ git checkout pull/6393
$ git pull https://git.openjdk.java.net/jdk pull/6393/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6393

View PR using the GUI difftool:
$ git pr show -t 6393

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6393.diff

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RogerRiggs The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[RogerRiggs]

/csr

[openjdk]

@RogerRiggs this pull request will not be integrated until the CSR request JDK-8276742 for issue JDK-8276665 has been approved.

[mlbridge]

Webrevs

• 01: Full - Incremental (085b3deb)
• 00: Full (dab6150f)

[naotoj]

Look good.

[openjdk]

⚠️ @RogerRiggs This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[RogerRiggs]

Note the addition of a system property "jdk.serialGetFieldCnfeReturnsNull" to revert to the old behavior
if there is an application dependency on the old behavior.

[openjdk]

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276665: ObjectInputStream.GetField.get(name, object) should throw ClassNotFoundException

Reviewed-by: naoto, lancea, smarks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 131 new commits pushed to the master branch:

• 7b2d823: 8277503: compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java failed with "OnSpinWaitInst with the expected value 'isb' not found."
• 7cb56a2: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with JEP 416
• 24e586a: 8276764: Enable deterministic file content ordering for Jar and Jmod
• ea85e01: 8271623: Omit enclosing instance fields from inner classes that don't use it
• 0320672: 8277451: java.lang.reflect.Field::set on static field with invalid argument type should throw IAE
• e8acac2: 8277350: runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java times out
• 8a44e09: 8268725: jshell does not support the --enable-native-access option
• 7b67a49: 8261847: performance of java.lang.Record::toString should be improved
• 38802ad: 8254108: ciReplay: Support incremental inlining
• 64bdc84: 8277649: [BACKOUT] JDK-8277507 Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures
• ... and 121 more: https://git.openjdk.java.net/jdk/compare/7fc344dc96008f277dacf5518b28447f3a598cde...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RogerRiggs]

/integrate

[openjdk]

Going to push as commit 0384739.
Since your change was applied there have been 138 commits pushed to the master branch:

• cf7adae: 8275320: NMT should perform buffer overrun checks
• 96e3607: 8275063: Implementation of Foreign Function & Memory API (Second incubator)
• 17e68ca: 8277042: add test for 8276036 to compiler/codecache
• 8a8bc29: 8277562: Remove dead method c1 If::swap_sux
• d085c2b: 8273328: Compiler implementation for Pattern Matching for switch (Second Preview)
• 6d73460: 8277399: ZGC: Move worker thread logging out of gc+phase=debug
• 712b875: 8277397: ZGC: Add JFR event for temporary latency measurements
• 7b2d823: 8277503: compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java failed with "OnSpinWaitInst with the expected value 'isb' not found."
• 7cb56a2: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with JEP 416
• 24e586a: 8276764: Enable deterministic file content ordering for Jar and Jmod
• ... and 128 more: https://git.openjdk.java.net/jdk/compare/7fc344dc96008f277dacf5518b28447f3a598cde...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RogerRiggs Pushed as commit 0384739.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.