New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points #6399
Conversation
…/user/* mount points
👋 Welcome back akasko! A progress list of the required criteria for merging this PR into |
Webrevs
|
@@ -22,7 +22,7 @@ | |||
*/ | |||
|
|||
/* @test | |||
* @bug 4313887 6873621 6979526 7006126 7020517 8264400 | |||
* @bug 4313887 6873621 6979526 7006126 7020517 8264400 8277159 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that the bug ID needs to be added here as this is a change to the test itself, only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comments! I've removed the bug ID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed 5 test repeats on Linux, macOS, and Windows. Approved.
@akashche This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 29 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bplb, @shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Thanks for the review! |
/integrate |
/sponsor |
Going to push as commit b687664.
Your commit was automatically rebased without conflicts. |
@zhengyu123 @akashche Pushed as commit b687664. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
…/user/* mount points
The fix to the test is the same as in #5136 . The possible problem with this test was identified in this comment, however FileSystemException is thrown instead of NoSuchFileException in this case, thus the special check for "/run/user" is added.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6399/head:pull/6399
$ git checkout pull/6399
Update a local copy of the PR:
$ git checkout pull/6399
$ git pull https://git.openjdk.java.net/jdk pull/6399/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6399
View PR using the GUI difftool:
$ git pr show -t 6399
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6399.diff