8266368: Inaccurate after_unwind hook in C2 exception handler

[fisk]

When we throw an exception and unwind into a frame, the exception handler of that frame needs to call an after_unwind hook for the StackWatermark code, to support for concurrent stack processing. Unfortunately, for C2 frames, I inaccurately do this in OptoRuntime::rethrow_C, but the exception handler when unwinding into a C2 frame really is OptoRuntime::handle_exception_C.
The handle_exception_C code does walk frames to the caller though, which also pokes the StackWatermark code. So in the end, there is no real bug here, but it works for the wrong reasons. So I'd like to move the hook in rethrow_C to handle_exception_C.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266368: Inaccurate after_unwind hook in C2 exception handler

Reviewers

• Dean Long (@dean-long - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6405/head:pull/6405
$ git checkout pull/6405

Update a local copy of the PR:
$ git checkout pull/6405
$ git pull https://git.openjdk.java.net/jdk pull/6405/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6405

View PR using the GUI difftool:
$ git pr show -t 6405

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6405.diff

[bridgekeeper]

👋 Welcome back eosterlund! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fisk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (845c2030)

[dean-long]

/cc hotspot-compiler

[openjdk]

@dean-long
The hotspot-compiler label was successfully added.

[dean-long]

Looks good!

[dean-long]

/reviewers 2

[openjdk]

@fisk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266368: Inaccurate after_unwind hook in C2 exception handler

Reviewed-by: dlong, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 156 new commits pushed to the master branch:

• db55f92: 8277343: dynamicArchive/SharedArchiveFileOption.java failed: '-XX:+RecordDynamicDumpInfo is unsupported when a dynamic CDS archive is specified in -XX:SharedArchiveFile:' missing
• 2f4b540: 8276314: [JVMCI] check alignment of call displacement during code installation
• 9160743: 8276058: Some swing test fails on specific CI macos system
• 8193800: 8274179: AArch64: Support SVE operations with encodable immediates
• b8453eb: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales
• 231fb61: 8276970: Default charset for PrintWriter that wraps PrintStream
• 29e552c: 8272358: Some tests may fail when executed with other locales than the US
• ce4471f: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64
• 45a60db: 8277045: G1: Remove unnecessary set_concurrency call in G1ConcurrentMark::weak_refs_work
• 6bb0462: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
• ... and 146 more: https://git.openjdk.java.net/jdk/compare/a74a839af02446d322d77c6e546e652ec6ad5d73...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dean-long
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[TobiHartmann]

Looks good.

[fisk]

Thanks for the reviews, @TobiHartmann and @dean-long.

[fisk]

/integrate

[openjdk]

Going to push as commit 2c06bca.
Since your change was applied there have been 158 commits pushed to the master branch:

• 77cc508: 8277215: Remove redundancy in ReferenceProcessor constructor args
• 0a65e8b: 8276794: Change nested classes in java.desktop to static nested classes
• db55f92: 8277343: dynamicArchive/SharedArchiveFileOption.java failed: '-XX:+RecordDynamicDumpInfo is unsupported when a dynamic CDS archive is specified in -XX:SharedArchiveFile:' missing
• 2f4b540: 8276314: [JVMCI] check alignment of call displacement during code installation
• 9160743: 8276058: Some swing test fails on specific CI macos system
• 8193800: 8274179: AArch64: Support SVE operations with encodable immediates
• b8453eb: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales
• 231fb61: 8276970: Default charset for PrintWriter that wraps PrintStream
• 29e552c: 8272358: Some tests may fail when executed with other locales than the US
• ce4471f: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64
• ... and 148 more: https://git.openjdk.java.net/jdk/compare/a74a839af02446d322d77c6e546e652ec6ad5d73...master

Your commit was automatically rebased without conflicts.

[openjdk]

@fisk Pushed as commit 2c06bca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.