New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277221: G1: Remove methods without implementations in G1CollectedHeap #6414
Conversation
|
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and trivial.
@albertnetymk This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Thanks for the review. /integrate |
Going to push as commit e9934e1.
Your commit was automatically rebased without conflicts. |
@albertnetymk Pushed as commit e9934e1. |
Trivial change of removing dead code.
Test: build
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6414/head:pull/6414
$ git checkout pull/6414
Update a local copy of the PR:
$ git checkout pull/6414
$ git pull https://git.openjdk.java.net/jdk pull/6414/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6414
View PR using the GUI difftool:
$ git pr show -t 6414
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6414.diff