8264293: Create implementation for NSAccessibilityMenu protocol peer #6421

azuev-java · 2021-11-16T23:53:53Z

Added implementation for all menu related protocol peers;
Native methods moved to CommonComponentAccessibility so they are called on correct peers;

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issues

JDK-8264293: Create implementation for NSAccessibilityMenu protocol peer
JDK-8264296: Create implementation for NSAccessibilityPopUpButton protocol peer
JDK-8264295: Create implementation for NSAccessibilityMenuItem protocol peer
JDK-8264294: Create implementation for NSAccessibilityMenuBar protocol peer

Reviewers

Pankaj Bansal (@pankaj-bansal - Reviewer) ⚠️ Review applies to 264f8ee
Anton Tarasov (@forantar - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6421/head:pull/6421
$ git checkout pull/6421

Update a local copy of the PR:
$ git checkout pull/6421
$ git pull https://git.openjdk.java.net/jdk pull/6421/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6421

View PR using the GUI difftool:
$ git pr show -t 6421

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6421.diff

Added implementation for menu related protocol peers. Moved native methods to CommonComponentAccessibility so they are called on correct peers.

bridgekeeper · 2021-11-16T23:55:02Z

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-11-16T23:57:10Z

@azuev-java The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

azuev-java · 2021-11-16T23:58:24Z

/issue add JDK-8264296,JDK-8264295,JDK-8264294

openjdk · 2021-11-16T23:59:00Z

@azuev-java
Adding additional issue to issue list: 8264296: Create implementation for NSAccessibilityPopUpButton protocol peer.

Adding additional issue to issue list: 8264295: Create implementation for NSAccessibilityMenuItem protocol peer.

Adding additional issue to issue list: 8264294: Create implementation for NSAccessibilityMenuBar protocol peer.

mlbridge · 2021-11-17T00:04:01Z

Webrevs

01: Full - Incremental (cedec290)
00: Full (264f8ee6)

victordyakov · 2021-11-17T00:11:50Z

@pankaj-bansal please review

victordyakov · 2021-11-17T00:12:06Z

@forantar please review

pankaj-bansal

Looks good to me. Menu Accessibility works fine with these changes.

openjdk · 2021-11-17T06:43:34Z

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264293: Create implementation for NSAccessibilityMenu protocol peer
8264296: Create implementation for NSAccessibilityPopUpButton protocol peer
8264295: Create implementation for NSAccessibilityMenuItem protocol peer
8264294: Create implementation for NSAccessibilityMenuBar protocol peer

Reviewed-by: pbansal, ant

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

9f2f46e: 8275037: Test vmTestbase/nsk/sysdict/vm/stress/btree/btree011/btree011.java crashes with memory exhaustion on Windows
2af9e59: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test
e9934e1: 8277221: G1: Remove methods without implementations in G1CollectedHeap
9aa30de: 8275317: AArch64: Support some type conversion vectorization in SLP
08f65a5: 8277313: Validate header failed for test/jdk/java/net/httpclient/HeadTest.java
23e5117: 8276559: (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request.
a77d8dd: 8276787: Improve warning messages for -XX:+RecordDynamicDumpInfo
8ed384c: 8276609: Document setting property jdk.serialFilter to an invalid value throws ExceptionInInitializerError
cddc6ce: 8275811: Incorrect instance to dispose
b0a463f: 8169468: NoResizeEventOnDMChangeTest.java fails because FS Window didn't receive all resizes!
... and 70 more: https://git.openjdk.java.net/jdk/compare/55b36c6f3bb7eb066daaf41f9eba46633afedf08...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

savoptik · 2021-11-17T09:45:16Z

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m

    [rolesMap setObject:@"ListAccessibility" forKey:@"list"];
    [rolesMap setObject:@"OutlineAccessibility" forKey:@"tree"];
    [rolesMap setObject:@"TableAccessibility" forKey:@"table"];
+    [rolesMap setObject:@"MenuBarAccessibility" forKey:@"menubar"];


Please increase the capacity of the rolesMap dictionary if you add a new role.

forantar · 2021-11-17T09:55:19Z

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m

+    JNI_COCOA_ENTER(env);
+    [ThreadUtilities performOnMainThread:@selector(postMenuOpened)
+        on:(CommonComponentAccessibility *)jlong_to_ptr(element)
+        withObject:nil waitUntilDone:NO];


Please move waitUntilDone to the new line for consistency.

forantar · 2021-11-17T09:55:39Z

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/MenuAccessibility.m

+@implementation MenuAccessibility
+- (NSAccessibilityRole _Nonnull)accessibilityRole
+{
+        return [[[self parent] javaRole] isEqualToString:@"combobox"]


Please correct the indentation.

forantar · 2021-11-17T09:58:14Z

Besides what @savoptik mentioned, I left only cosmetics comments. Overall looks ok to me.

Fixed initial capacity of rolesMap dictionary;

azuev-java · 2021-11-17T16:52:40Z

Besides what @savoptik mentioned, I left only cosmetics comments. Overall looks ok to me.

Cosmetics are also important so i fixed them too.

forantar · 2021-11-17T17:05:18Z

Looks fine now.

azuev-java · 2021-11-17T17:12:54Z

/integrate

openjdk · 2021-11-17T17:37:53Z

Going to push as commit 8f5a8f7.
Since your change was applied there have been 80 commits pushed to the master branch:

9f2f46e: 8275037: Test vmTestbase/nsk/sysdict/vm/stress/btree/btree011/btree011.java crashes with memory exhaustion on Windows
2af9e59: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test
e9934e1: 8277221: G1: Remove methods without implementations in G1CollectedHeap
9aa30de: 8275317: AArch64: Support some type conversion vectorization in SLP
08f65a5: 8277313: Validate header failed for test/jdk/java/net/httpclient/HeadTest.java
23e5117: 8276559: (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request.
a77d8dd: 8276787: Improve warning messages for -XX:+RecordDynamicDumpInfo
8ed384c: 8276609: Document setting property jdk.serialFilter to an invalid value throws ExceptionInInitializerError
cddc6ce: 8275811: Incorrect instance to dispose
b0a463f: 8169468: NoResizeEventOnDMChangeTest.java fails because FS Window didn't receive all resizes!
... and 70 more: https://git.openjdk.java.net/jdk/compare/55b36c6f3bb7eb066daaf41f9eba46633afedf08...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-11-17T17:39:09Z

@azuev-java Pushed as commit 8f5a8f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8264293: Create implementation for NSAccessibilityMenu protocol peer

264f8ee

Added implementation for menu related protocol peers. Moved native methods to CommonComponentAccessibility so they are called on correct peers.

openjdk bot added the rfr Pull request is ready for review label Nov 16, 2021

openjdk bot added the client client-libs-dev@openjdk.org label Nov 16, 2021

pankaj-bansal approved these changes Nov 17, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 17, 2021

savoptik reviewed Nov 17, 2021

View reviewed changes

forantar reviewed Nov 17, 2021

View reviewed changes

azuev-java added 2 commits November 17, 2021 08:48

Fixed indentation of native methods;

978f8b8

Fixed initial capacity of rolesMap dictionary;

Fixed parameters layout for better readeability;

cedec29

forantar approved these changes Nov 17, 2021

View reviewed changes

openjdk bot closed this Nov 17, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 17, 2021

azuev-java deleted the JDK-8264293 branch January 31, 2022 09:38

8264293: Create implementation for NSAccessibilityMenu protocol peer #6421

8264293: Create implementation for NSAccessibilityMenu protocol peer #6421

Uh oh!

Conversation

azuev-java commented Nov 16, 2021 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issues

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Nov 16, 2021

Uh oh!

openjdk bot commented Nov 16, 2021

Uh oh!

azuev-java commented Nov 16, 2021

Uh oh!

openjdk bot commented Nov 16, 2021

Uh oh!

mlbridge bot commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

victordyakov commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

victordyakov commented Nov 17, 2021

Uh oh!

pankaj-bansal left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

savoptik Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

azuev-java Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

forantar Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

azuev-java Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

forantar Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

azuev-java Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

forantar commented Nov 17, 2021

Uh oh!

azuev-java commented Nov 17, 2021

Uh oh!

forantar commented Nov 17, 2021

Uh oh!

azuev-java commented Nov 17, 2021

Uh oh!

openjdk bot commented Nov 17, 2021

Uh oh!

openjdk bot commented Nov 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

azuev-java commented Nov 16, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Nov 17, 2021 •

edited

Loading

victordyakov commented Nov 17, 2021 •

edited

Loading

openjdk bot commented Nov 17, 2021 •

edited

Loading