Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277313: Validate header failed for test/jdk/java/net/httpclient/HeadTest.java #6424

Closed
wants to merge 1 commit into from

Conversation

fmatte1
Copy link

@fmatte1 fmatte1 commented Nov 17, 2021

With the integration of JDK-8276559, validate header failed as there is one missing comma after 2021 in test/jdk/java/net/httpclient/HeadTest.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277313: Validate header failed for test/jdk/java/net/httpclient/HeadTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6424/head:pull/6424
$ git checkout pull/6424

Update a local copy of the PR:
$ git checkout pull/6424
$ git pull https://git.openjdk.java.net/jdk pull/6424/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6424

View PR using the GUI difftool:
$ git pr show -t 6424

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6424.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 17, 2021

👋 Welcome back fmatte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@fmatte1 The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net label Nov 17, 2021
@jaikiran
Copy link
Member

@jaikiran jaikiran commented Nov 17, 2021

Thank you for fixing this @fmatte1. I'm not a Reviewer, but this looks good to me.

Could you tell me which test identified this issue, so that I can in future run them locally if feasible?

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 17, 2021

Webrevs

@fmatte1
Copy link
Author

@fmatte1 fmatte1 commented Nov 17, 2021

Thank you for fixing this @fmatte1. I'm not a Reviewer, but this looks good to me.

Could you tell me which test identified this issue, so that I can in future run them locally if feasible?

Thanks Jaikiran for the review, it is test/jdk/java/net/httpclient/HeadTest.java you have missed one comma(,) after 2021 in the header field. We internally validate headers that script has caught this.

@jaikiran
Copy link
Member

@jaikiran jaikiran commented Nov 17, 2021

We internally validate headers that script has caught this.

Thank you, that answers my question.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@fmatte1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277313: Validate header failed for test/jdk/java/net/httpclient/HeadTest.java

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jayathirthrao) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 17, 2021
@fmatte1
Copy link
Author

@fmatte1 fmatte1 commented Nov 17, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@fmatte1
Your change (at version bdbbf4f) is now ready to be sponsored by a Committer.

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Nov 17, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

Going to push as commit 08f65a5.

@openjdk openjdk bot closed this Nov 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@jayathirthrao @fmatte1 Pushed as commit 08f65a5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net
3 participants