New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277239: SIGSEGV in vrshift_reg_maskedNode::emit #6431
Conversation
👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into |
/label hotspot-compiler-dev |
@jatin-bhateja |
Webrevs
|
Running tests to verify. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks good to me.
@jatin-bhateja This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 90 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Tests passed. Needs another HotSpot reviewer. |
@@ -523,10 +523,11 @@ bool LibraryCallKit::inline_vector_nary_operation(int n) { | |||
} | |||
} else { | |||
const TypeVect* vt = TypeVect::make(elem_bt, num_elem, is_vector_mask(vbox_klass)); | |||
bool is_var_shift = VectorNode::is_shift_opcode(opc); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about moving this down to where it is used?
Thanks @sviswa7 and @dean-long |
/integrate |
Going to push as commit e529865.
Your commit was automatically rebased without conflicts. |
@jatin-bhateja Pushed as commit e529865. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Currently instruction selector differentiates between the two kinds of vector shift operations i.e. one with vector shift count and other with scalar shift count passed though LShiftCntV/RShiftCntV nodes by looking at the ideal opcode of shift count node.
A more robust scheme is to set a flag over vector shift node if it has variable vector shift count and replace the opcode based check with flag based check in various shift instruction selection patterns.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6431/head:pull/6431
$ git checkout pull/6431
Update a local copy of the PR:
$ git checkout pull/6431
$ git pull https://git.openjdk.java.net/jdk pull/6431/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6431
View PR using the GUI difftool:
$ git pr show -t 6431
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6431.diff