Skip to content

8277239: SIGSEGV in vrshift_reg_maskedNode::emit #6431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8277239: SIGSEGV in vrshift_reg_maskedNode::emit #6431

wants to merge 2 commits into from

Conversation

jatin-bhateja
Copy link
Member

@jatin-bhateja jatin-bhateja commented Nov 17, 2021 •
edited by openjdk bot
Loading

Currently instruction selector differentiates between the two kinds of vector shift operations i.e. one with vector shift count and other with scalar shift count passed though LShiftCntV/RShiftCntV nodes by looking at the ideal opcode of shift count node.

A more robust scheme is to set a flag over vector shift node if it has variable vector shift count and replace the opcode based check with flag based check in various shift instruction selection patterns.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6431/head:pull/6431
$ git checkout pull/6431

Update a local copy of the PR:
$ git checkout pull/6431
$ git pull https://git.openjdk.java.net/jdk pull/6431/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6431

View PR using the GUI difftool:
$ git pr show -t 6431

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6431.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2021

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jatin-bhateja
Copy link
Member Author

/label hotspot-compiler-dev

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-compiler hotspot-compiler-dev@openjdk.org labels Nov 17, 2021
@openjdk
Copy link

openjdk bot commented Nov 17, 2021

@jatin-bhateja
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 17, 2021 •
edited
Loading

Webrevs

@PaulSandoz
Copy link
Member

Running tests to verify.

sviswa7
sviswa7 approved these changes Nov 18, 2021
View reviewed changes
Copy link

@sviswa7 sviswa7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good to me.

@openjdk
Copy link

openjdk bot commented Nov 18, 2021 •
edited
Loading

@jatin-bhateja This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277239: SIGSEGV in vrshift_reg_maskedNode::emit

Reviewed-by: sviswanathan, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 90 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2021
@PaulSandoz
Copy link
Member

Tests passed. Needs another HotSpot reviewer.

dean-long
dean-long suggested changes Nov 20, 2021
View reviewed changes
src/hotspot/share/opto/vectorIntrinsics.cpp Outdated
@@ -523,10 +523,11 @@ bool LibraryCallKit::inline_vector_nary_operation(int n) {
}
} else {
const TypeVect* vt = TypeVect::make(elem_bt, num_elem, is_vector_mask(vbox_klass));
bool is_var_shift = VectorNode::is_shift_opcode(opc);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about moving this down to where it is used?

@jatin-bhateja
Copy link
Member Author

Thanks @sviswa7 and @dean-long

@jatin-bhateja
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 22, 2021

Going to push as commit e529865.
Since your change was applied there have been 94 commits pushed to the master branch:

  • 8683de5: 8274685: Documentation suggests there are ArbitrarilyJumpableGenerator when none
  • 6b4fbae: 8273792: JumpableGenerator.rngs() documentation refers to wrong method
  • d427c79: 8277428: G1: Move and inline G1STWIsAliveClosure::do_object_b
  • 32839ba: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"
  • 8051041: 8277534: Remove unused ReferenceProcessor::has_discovered_references
  • 3f847fe: 8277385: Zero: Enable CompactStrings support
  • ca31ed5: 8275448: [REDO] AArch64: Implement string_compare intrinsic in SVE
  • 4ff4301: 8224922: Access JavaFileObject from Element(s)
  • 0a9e76c: 8277485: Zero: Fix fast{i,f}access_0 bytecodes handling
  • 1c215f3: 8272773: Configurable card table card size
  • ... and 84 more: https://git.openjdk.java.net/jdk/compare/bd92674be563ad291990216b7cdf061c498f5dd3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2021
@openjdk
Copy link

openjdk bot commented Nov 22, 2021

@jatin-bhateja Pushed as commit e529865.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jatin-bhateja jatin-bhateja deleted the JDK-8277239 branch December 6, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dean-long dean-long dean-long approved these changes

@sviswa7 sviswa7 sviswa7 approved these changes

Assignees
No one assigned
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jatin-bhateja @PaulSandoz @dean-long @sviswa7