Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277504: Use String.stripTrailing instead of hand-crafted method in SwingUtilities2 #6436

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Nov 17, 2021

There is opportunity to use String.stripTrailing() method in java.desktop in SwingUtilities2 class.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277504: Use String.stripTrailing instead of hand-crafted method in SwingUtilities2

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6436/head:pull/6436
$ git checkout pull/6436

Update a local copy of the PR:
$ git checkout pull/6436
$ git pull https://git.openjdk.java.net/jdk pull/6436/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6436

View PR using the GUI difftool:
$ git pr show -t 6436

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6436.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 17, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Nov 17, 2021
@mrserb
Copy link
Member

@mrserb mrserb commented Nov 17, 2021

Probably all those typos can be fixed separately?

@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Nov 18, 2021

Probably all those typos can be fixed separately?

Okay. Reverted them.

@mrserb
Copy link
Member

@mrserb mrserb commented Nov 19, 2021

Looks fine.

@turbanoff turbanoff changed the title [PATCH] Use String.stripTrailing instead of hand-crafted method in SwingUtilities2 8277504: Use String.stripTrailing instead of hand-crafted method in SwingUtilities2 Nov 20, 2021
@openjdk openjdk bot added the rfr label Nov 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 20, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277504: Use String.stripTrailing instead of hand-crafted method in SwingUtilities2

Reviewed-by: pbansal, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

  • 7b2d823: 8277503: compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java failed with "OnSpinWaitInst with the expected value 'isb' not found."
  • 7cb56a2: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with JEP 416
  • 24e586a: 8276764: Enable deterministic file content ordering for Jar and Jmod
  • ea85e01: 8271623: Omit enclosing instance fields from inner classes that don't use it
  • 0320672: 8277451: java.lang.reflect.Field::set on static field with invalid argument type should throw IAE
  • e8acac2: 8277350: runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java times out
  • 8a44e09: 8268725: jshell does not support the --enable-native-access option
  • 7b67a49: 8261847: performance of java.lang.Record::toString should be improved
  • 38802ad: 8254108: ciReplay: Support incremental inlining
  • 64bdc84: 8277649: [BACKOUT] JDK-8277507 Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures
  • ... and 86 more: https://git.openjdk.java.net/jdk/compare/b6876649a82bed508d817ccbde1600d00937e4b2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@pankaj-bansal, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 22, 2021
mrserb
mrserb approved these changes Nov 22, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Nov 24, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 24, 2021

@turbanoff
Your change (at version 2e73124) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

@mrserb mrserb commented Nov 26, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2021

Going to push as commit eb4d886.
Since your change was applied there have been 117 commits pushed to the master branch:

  • 9879920: 8277825: Remove unused ReferenceProcessorPhaseTimes::_sub_phases_total_time_ms
  • f788834: 8277786: G1: Rename log2_card_region_per_heap_region used in G1CardSet
  • 3034ae8: 8277631: ZGC: CriticalMetaspaceAllocation asserts
  • f0136ec: 8275687: runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException
  • 21e302a: 8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find too_many string in output
  • a81e4fc: 8258117: jar tool sets the time stamp of module-info.class entries to the current time
  • 26472bd: 8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
  • b5841ba: 8277806: 4 tools/jar failures per platform after JDK-8272728
  • e785f69: 8276124: Provide snippet support for properties files
  • 96fe1d0: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"
  • ... and 107 more: https://git.openjdk.java.net/jdk/compare/b6876649a82bed508d817ccbde1600d00937e4b2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2021

@mrserb @turbanoff Pushed as commit eb4d886.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the use_String.stripTrailing_in_SwingUtilities2 branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
3 participants