8277343: dynamicArchive/SharedArchiveFileOption.java failed: '-XX:+RecordDynamicDumpInfo is unsupported when a dynamic CDS archive is specified in -XX:SharedArchiveFile:' missing

[iklam]

Please fix this trivial fix. The affected test case expected the following message

-XX:+RecordDynamicDumpInfo is unsupported when a dynamic CDS archive is specified in -XX:SharedArchiveFile: 

but if we run with jtreg -vmoption:-Xshare:off the test case takes a different path, resulting in a different message:

Cannot have more than 1 archive file specified in -XX:SharedArchiveFile during CDS dumping

Since the latter message is already being tested in another case in SharedArchiveFileOption.java, we can simple disable this test case under this condition.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8277343: dynamicArchive/SharedArchiveFileOption.java failed: '-XX:+RecordDynamicDumpInfo is unsupported when a dynamic CDS archive is specified in -XX:SharedArchiveFile:' missing

Reviewers

• Harold Seigel (@hseigel - Reviewer)
• Calvin Cheung (@calvinccheung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6437/head:pull/6437
$ git checkout pull/6437

Update a local copy of the PR:
$ git checkout pull/6437
$ git pull https://git.openjdk.java.net/jdk pull/6437/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6437

View PR using the GUI difftool:
$ git pr show -t 6437

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6437.diff

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (929ba18f)

[hseigel]

Looks good and trival. Thanks for fixing this.
Harold

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277343: dynamicArchive/SharedArchiveFileOption.java failed: '-XX:+RecordDynamicDumpInfo is unsupported when a dynamic CDS archive is specified in -XX:SharedArchiveFile:' missing

Reviewed-by: hseigel, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• ce4471f: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64
• 45a60db: 8277045: G1: Remove unnecessary set_concurrency call in G1ConcurrentMark::weak_refs_work
• 6bb0462: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
• d8c0280: 8277316: ciReplay: dump_replay_data is not thread-safe
• 007ad7c: 8277303: Terminology mismatch between JLS17-3.9 and SE17's javax.lang.model.SourceVersion method specs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[calvinccheung]

LGTM.

[iklam]

Thanks @calvinccheung and @hseigel for the review.
/integrate

[openjdk]

Going to push as commit db55f92.
Since your change was applied there have been 11 commits pushed to the master branch:

• 2f4b540: 8276314: [JVMCI] check alignment of call displacement during code installation
• 9160743: 8276058: Some swing test fails on specific CI macos system
• 8193800: 8274179: AArch64: Support SVE operations with encodable immediates
• b8453eb: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales
• 231fb61: 8276970: Default charset for PrintWriter that wraps PrintStream
• 29e552c: 8272358: Some tests may fail when executed with other locales than the US
• ce4471f: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64
• 45a60db: 8277045: G1: Remove unnecessary set_concurrency call in G1ConcurrentMark::weak_refs_work
• 6bb0462: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
• d8c0280: 8277316: ciReplay: dump_replay_data is not thread-safe
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/8881f29bc83336bcbc0e8ff0cf1d2bbe55172f5c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit db55f92.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.