Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277346: ProblemList 7 serviceability/sa tests on macosx-x64 #6438

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Nov 17, 2021

A trivial fix to ProblemList 7 serviceability/sa tests on macosx-x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8277346: ProblemList 7 serviceability/sa tests on macosx-x64
  • JDK-8277351: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on macosx-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6438/head:pull/6438
$ git checkout pull/6438

Update a local copy of the PR:
$ git checkout pull/6438
$ git pull https://git.openjdk.java.net/jdk pull/6438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6438

View PR using the GUI difftool:
$ git pr show -t 6438

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6438.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 17, 2021

/label add hotspot-runtime
/label add serviceability

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 17, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime label Nov 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability label Nov 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@dcubed-ojdk
The serviceability label was successfully added.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 17, 2021

/issue JDK-8277346
/issue JDK-8277351

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Nov 17, 2021
@openjdk openjdk bot added the rfr label Nov 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8277351: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on macosx-x64.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 17, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm and trivial

bplb
bplb approved these changes Nov 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277346: ProblemList 7 serviceability/sa tests on macosx-x64
8277351: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on macosx-x64

Reviewed-by: tschatzl, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 45a60db: 8277045: G1: Remove unnecessary set_concurrency call in G1ConcurrentMark::weak_refs_work
  • 6bb0462: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
  • d8c0280: 8277316: ciReplay: dump_replay_data is not thread-safe
  • 007ad7c: 8277303: Terminology mismatch between JLS17-3.9 and SE17's javax.lang.model.SourceVersion method specs
  • 8881f29: 8277310: ciReplay: @CPI MethodHandle references not resolved

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 17, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 17, 2021

@tschatzl and @bplb - Thanks for the fast review!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

Going to push as commit ce4471f.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 45a60db: 8277045: G1: Remove unnecessary set_concurrency call in G1ConcurrentMark::weak_refs_work
  • 6bb0462: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
  • d8c0280: 8277316: ciReplay: dump_replay_data is not thread-safe
  • 007ad7c: 8277303: Terminology mismatch between JLS17-3.9 and SE17's javax.lang.model.SourceVersion method specs
  • 8881f29: 8277310: ciReplay: @CPI MethodHandle references not resolved

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@dcubed-ojdk Pushed as commit ce4471f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8277346 branch Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated serviceability
3 participants