JDK-8277092: TestMetaspaceAllocationMT2.java#ndebug-default fails with "RuntimeException: Committed seems high: NNNN expected at most MMMM"

[tstuefe]

Test error after JDK-8276731. That patch changed the way metaspace chunks are uncommitted: Before, chunks were uncommitted when being returned to the system; now they are uncommitted only if Metaspace::purge() is explicitly called.

In real VM life, that makes no difference since these two things happen back to back in CLDG::purge().

But these metaspace tests isolate metaspace arenas and test them as individual units, without involving GC or CLDG, and therefore we need to purge manually. Otherwise, the commit numbers are unpredictable and may be larger than expected.

Tests: manual x64+x86, GHAs (one unrelated error in hs compiler tests on linux x64), SAP nightlies

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8277092: TestMetaspaceAllocationMT2.java#ndebug-default fails with "RuntimeException: Committed seems high: NNNN expected at most MMMM"

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6451/head:pull/6451
$ git checkout pull/6451

Update a local copy of the PR:
$ git checkout pull/6451
$ git pull https://git.openjdk.java.net/jdk pull/6451/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6451

View PR using the GUI difftool:
$ git pr show -t 6451

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6451.diff

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[tstuefe]

GHA display is off; the only real test error is linux x64 hotspot compiler, but that has nothing to do with this change.

[mlbridge]

Webrevs

• 00: Full (525a285a)

[coleenp]

Ok, I found where it calls ChunkManager::purge. This looks good. I think as a test fix, it can be integrated as "trivial".

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277092: TestMetaspaceAllocationMT2.java#ndebug-default fails with "RuntimeException: Committed seems high: NNNN expected at most MMMM"

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

• e47cc81: 8275386: Change nested classes in jdk.jlink to static nested classes
• f609b8f: 8274946: Cleanup unnecessary calls to Throwable.initCause() in java.rmi
• 36b59f3: 8274333: Redundant null comparison after Pattern.split
• 6677554: 8274949: Use String.contains() instead of String.indexOf() in java.base
• 09e8c8c: 8277342: vmTestbase/nsk/stress/strace/strace004.java fails with SIGSEGV in InstanceKlass::jni_id_for
• 976c2bb: 8277212: GC accidentally cleans valid megamorphic vtable inline caches
• 03f8c0f: 8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled
• 936f7ff: 8276150: Quarantined jpackage apps are labeled as "damaged"
• a022796: 8275745: Reproducible copyright headers
• b1a1bf4: 8277427: Update jib-profiles.js to use JMH 1.33 devkit
• ... and 49 more: https://git.openjdk.java.net/jdk/compare/23e5117a55b3f3d0e3d26bf2d481f4ad1c99af57...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Ok, I found where it calls ChunkManager::purge. This looks good. I think as a test fix, it can be integrated as "trivial".

Thank you, Coleen. The one remaining test error is unrelated (actually, compiler/c2/irTests/TestUnsignedComparison.java fails in all my GHAs currently).

/integrate

[openjdk]

Going to push as commit a3406a1.
Since your change was applied there have been 59 commits pushed to the master branch:

• e47cc81: 8275386: Change nested classes in jdk.jlink to static nested classes
• f609b8f: 8274946: Cleanup unnecessary calls to Throwable.initCause() in java.rmi
• 36b59f3: 8274333: Redundant null comparison after Pattern.split
• 6677554: 8274949: Use String.contains() instead of String.indexOf() in java.base
• 09e8c8c: 8277342: vmTestbase/nsk/stress/strace/strace004.java fails with SIGSEGV in InstanceKlass::jni_id_for
• 976c2bb: 8277212: GC accidentally cleans valid megamorphic vtable inline caches
• 03f8c0f: 8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled
• 936f7ff: 8276150: Quarantined jpackage apps are labeled as "damaged"
• a022796: 8275745: Reproducible copyright headers
• b1a1bf4: 8277427: Update jib-profiles.js to use JMH 1.33 devkit
• ... and 49 more: https://git.openjdk.java.net/jdk/compare/23e5117a55b3f3d0e3d26bf2d481f4ad1c99af57...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit a3406a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.