Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277394: Remove the use of safepoint_workers in reference processor #6453

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Nov 18, 2021

Simple change of passing workers to the reference processor constructor.

Test: hotspot_gc


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277394: Remove the use of safepoint_workers in reference processor

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6453/head:pull/6453
$ git checkout pull/6453

Update a local copy of the PR:
$ git checkout pull/6453
$ git pull https://git.openjdk.java.net/jdk pull/6453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6453

View PR using the GUI difftool:
$ git pr show -t 6453

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6453.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 18, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 18, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 18, 2021

Webrevs

@@ -253,6 +253,9 @@ class ReferenceProcessor : public ReferenceDiscoverer {
DiscoveredList* _discoveredFinalRefs;
DiscoveredList* _discoveredPhantomRefs;

// Workers to process the discovered non-strong references.
WorkerThreads* _workers;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding a WorkerThreads member at construction time, it seems better to me to add an argument to ReferenceProcessor::run_task.

Copy link
Member Author

@albertnetymk albertnetymk Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a ref-processor is instantiated, the caller specifies #worker to use for ref-processing. Since #workers and the worker-pool are related, I think it's conceptually cleaner that they are set in the same place.

Using the arg approach would mean that an extra arg has to be passed through run_task <- (process_soft_weak_final_refs | process_final_keep_alive | process_phantom_refs) <- process_discovered_references; this seems harder to follow where workers comes from.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 11, 2022

@albertnetymk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 8, 2022

@albertnetymk This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc rfr
2 participants