Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277414: ProblemList runtime/CommandLine/VMDeprecatedOptions.java on windows-x64 #6460

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Nov 18, 2021

A trivial fix to ProblemList runtime/CommandLine/VMDeprecatedOptions.java on windows-x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277414: ProblemList runtime/CommandLine/VMDeprecatedOptions.java on windows-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6460/head:pull/6460
$ git checkout pull/6460

Update a local copy of the PR:
$ git checkout pull/6460
$ git pull https://git.openjdk.java.net/jdk pull/6460/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6460

View PR using the GUI difftool:
$ git pr show -t 6460

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6460.diff

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Nov 18, 2021

/label add hotspot-runtime

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Nov 18, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Nov 18, 2021
@openjdk
Copy link

openjdk bot commented Nov 18, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

vidmik
vidmik approved these changes Nov 18, 2021
@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Nov 18, 2021

@vidmik - Thanks for the fast review!

I'm still trying to reach @hseigel to get an ETA on his fix...
Maybe I should just go ahead and integrate and he can update his PR to undo this one...

@openjdk
Copy link

openjdk bot commented Nov 18, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277414: ProblemList runtime/CommandLine/VMDeprecatedOptions.java on windows-x64

Reviewed-by: mikael, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 03473b4: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2021

Webrevs

iklam
iklam approved these changes Nov 18, 2021
@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Nov 18, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 18, 2021

Going to push as commit 8db0c36.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 03473b4: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2021
@openjdk
Copy link

openjdk bot commented Nov 18, 2021

@dcubed-ojdk Pushed as commit 8db0c36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8277414 branch Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants