-
Notifications
You must be signed in to change notification settings - Fork 6k
8277404: Test VMDeprecatedOptions.java failing with Unable to create shared archive file #6463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…shared archive file
👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up. I agree that this is a trivial fix.
@hseigel This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks Dan for reviewing this! /integrate |
Please review this trivial fix so that test VMDeprecatedVMOptions.java runs with the CDS options set to false. This prevents the test from trying to dump an archive and prevents it from trying to force usage of the CDS archive.
The fix was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows.
Thanks, Harold
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6463/head:pull/6463
$ git checkout pull/6463
Update a local copy of the PR:
$ git checkout pull/6463
$ git pull https://git.openjdk.java.net/jdk pull/6463/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6463
View PR using the GUI difftool:
$ git pr show -t 6463
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6463.diff