-
Notifications
You must be signed in to change notification settings - Fork 6k
8277428: G1: Move and inline G1STWIsAliveClosure::do_object_b #6470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277428: G1: Move and inline G1STWIsAliveClosure::do_object_b #6470
Conversation
👋 Welcome back mli! A progress list of the required criteria for merging this PR into |
@Hamlin-Li The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without checking performance, I think the definition should be moved to g1CollectedHeap.inline.hpp
, not the .cpp file (and includes fixed up).
It's used on every reference for a few operations.
@Hamlin-Li this pull request can not be integrated into git checkout move-G1STWIsAliveClosure-do_object_b
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
Thanks Thomas. Not sure if this method be inlined in original code, but I inline it anyway as you suggested. |
A lot of the changes to include |
Thanks Stefan, I remove the unnecessary inline includes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@Hamlin-Li This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Going to push as commit d427c79.
Your commit was automatically rebased without conflicts. |
@Hamlin-Li Pushed as commit d427c79. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a trivial patch to move G1STWIsAliveClosure::do_object_b definition to the right file g1CollectedHeap.inline.hpp.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6470/head:pull/6470
$ git checkout pull/6470
Update a local copy of the PR:
$ git checkout pull/6470
$ git pull https://git.openjdk.java.net/jdk pull/6470/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6470
View PR using the GUI difftool:
$ git pr show -t 6470
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6470.diff