Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277449: compiler/vectorapi/TestLongVectorNeg.java fails with release VMs #6476

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Nov 19, 2021

Hi all,

Please review this trivial fix.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277449: compiler/vectorapi/TestLongVectorNeg.java fails with release VMs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6476/head:pull/6476
$ git checkout pull/6476

Update a local copy of the PR:
$ git checkout pull/6476
$ git pull https://git.openjdk.java.net/jdk pull/6476/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6476

View PR using the GUI difftool:
$ git pr show -t 6476

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6476.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 19, 2021
@openjdk
Copy link

openjdk bot commented Nov 19, 2021

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 19, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2021

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good and trivial. Thanks for fixing.

@openjdk
Copy link

openjdk bot commented Nov 19, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277449: compiler/vectorapi/TestLongVectorNeg.java fails with release VMs

Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 19, 2021
Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good.

@DamonFool
Copy link
Member Author

DamonFool commented Nov 19, 2021

Thanks @TobiHartmann and @chhagedorn .
/integrate

@openjdk
Copy link

openjdk bot commented Nov 19, 2021

Going to push as commit b15e6f0.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 11d819d: 8277439: G1: Correct include guard name in G1EvacFailureObjectsSet.hpp

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 19, 2021
@DamonFool DamonFool deleted the JDK-8277449 branch Nov 19, 2021
@openjdk
Copy link

openjdk bot commented Nov 19, 2021

@DamonFool Pushed as commit b15e6f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants