Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged" #6483

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Nov 19, 2021

This reverts commit 936f7ff.

So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this [BACKOUT] has
passed the macosx-aarch64 test task that was failing before.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6483/head:pull/6483
$ git checkout pull/6483

Update a local copy of the PR:
$ git checkout pull/6483
$ git pull https://git.openjdk.java.net/jdk pull/6483/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6483

View PR using the GUI difftool:
$ git pr show -t 6483

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6483.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 19, 2021

/label add hotspot-runtime
/label add core-libs

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 19, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime label Nov 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Nov 19, 2021
@openjdk openjdk bot added rfr core-libs labels Nov 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

@dcubed-ojdk
The core-libs label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 19, 2021

Webrevs

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 19, 2021

My Mach5 Tier2 of this [BACKOUT] has passed all tests on all platforms.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 19, 2021

My Mach5 Tier2 of the baseline(master) with the fix for JDK-8276150
has reproduced the 31 failures on macosx-aarch64. So that's now 4
Tier2 job sets that have seen the failures.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged"

Reviewed-by: asemenyuk, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 2ab43ec: 8273544: Increase test coverage for snippets
  • 2d4af22: 8277370: configure script cannot distinguish WSL version
  • a3406a1: 8277092: TestMetaspaceAllocationMT2.java#ndebug-default fails with "RuntimeException: Committed seems high: NNNN expected at most MMMM"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 19, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 19, 2021

@alexeysemenyukoracle and @tschatzl - Thanks for the reviews!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

Going to push as commit c79a485.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 2ab43ec: 8273544: Increase test coverage for snippets
  • 2d4af22: 8277370: configure script cannot distinguish WSL version
  • a3406a1: 8277092: TestMetaspaceAllocationMT2.java#ndebug-default fails with "RuntimeException: Committed seems high: NNNN expected at most MMMM"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

@dcubed-ojdk Pushed as commit c79a485.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8277494 branch Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs hotspot-runtime integrated
3 participants