Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277429: Conflicting jpackage static library name #6485

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Nov 20, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277429: Conflicting jpackage static library name

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6485/head:pull/6485
$ git checkout pull/6485

Update a local copy of the PR:
$ git checkout pull/6485
$ git pull https://git.openjdk.java.net/jdk pull/6485/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6485

View PR using the GUI difftool:
$ git pr show -t 6485

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6485.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2021

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2021

@alexeysemenyukoracle The following labels will be automatically applied to this pull request:

  • build
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review labels Nov 20, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 20, 2021

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277429: Conflicting jpackage static library name

Reviewed-by: almatvee, herrick, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 95 new commits pushed to the master branch:

  • d427c79: 8277428: G1: Move and inline G1STWIsAliveClosure::do_object_b
  • 32839ba: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"
  • 8051041: 8277534: Remove unused ReferenceProcessor::has_discovered_references
  • 3f847fe: 8277385: Zero: Enable CompactStrings support
  • ca31ed5: 8275448: [REDO] AArch64: Implement string_compare intrinsic in SVE
  • 4ff4301: 8224922: Access JavaFileObject from Element(s)
  • 0a9e76c: 8277485: Zero: Fix fast{i,f}access_0 bytecodes handling
  • 1c215f3: 8272773: Configurable card table card size
  • 1d7cef3: 8276662: Scalability bottleneck in SymbolTable::lookup_common()
  • c79a485: 8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged"
  • ... and 85 more: https://git.openjdk.java.net/jdk/compare/7a870418a3e8de3b290ba71cbe4ca7979ec029f9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 20, 2021
@magicus
Copy link
Member

magicus commented Nov 22, 2021

How come BUILD_JPACKAGE_APPLAUNCHEREXE results in a library? It sounds like an executable...

@magicus
Copy link
Member

magicus commented Nov 22, 2021

That is, I realize this patch fixes the problem as described, I just don't understand why it happens, so maybe we're solving the symptoms and not the problem.

@erikj79
Copy link
Member

erikj79 commented Nov 22, 2021

The problem arises when running the "static-libs" build, where every library and executable is just linked into a static-lib for downstream consumers (Graal).

@alexeysemenyukoracle
Copy link
Member Author

alexeysemenyukoracle commented Nov 22, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 22, 2021

Going to push as commit e3911a8.
Since your change was applied there have been 100 commits pushed to the master branch:

  • 33e2a51: 8265795: vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java fails when running with JEP 416
  • 22f12ac: 8277522: Make formatting of null consistent in Elements
  • e529865: 8277239: SIGSEGV in vrshift_reg_maskedNode::emit
  • 8683de5: 8274685: Documentation suggests there are ArbitrarilyJumpableGenerator when none
  • 6b4fbae: 8273792: JumpableGenerator.rngs() documentation refers to wrong method
  • d427c79: 8277428: G1: Move and inline G1STWIsAliveClosure::do_object_b
  • 32839ba: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"
  • 8051041: 8277534: Remove unused ReferenceProcessor::has_discovered_references
  • 3f847fe: 8277385: Zero: Enable CompactStrings support
  • ca31ed5: 8275448: [REDO] AArch64: Implement string_compare intrinsic in SVE
  • ... and 90 more: https://git.openjdk.java.net/jdk/compare/7a870418a3e8de3b290ba71cbe4ca7979ec029f9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2021
@openjdk
Copy link

openjdk bot commented Nov 22, 2021

@alexeysemenyukoracle Pushed as commit e3911a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus
Copy link
Member

magicus commented Nov 23, 2021

Ok, I'm still a bit confused. Are executables converted to static libs (with a main method?) when doing static builds? I thought this affected only dynamic libraries. Are we sure that this functionality is actually needed? That is, should we not instead stop doing static libraries of executables (and either just ignore them, or keep creating executables) when doing static builds?

(I'm still not convinced this is the correct resolution, even though the change is pushed)

@alexeysemenyukoracle alexeysemenyukoracle deleted the JDK-8277429 branch Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants