Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8276681: Additional malformed Javadoc inline tags in JDK source #6486

Closed
wants to merge 3 commits into from

Conversation

tprinzing
Copy link
Contributor

@tprinzing tprinzing commented Nov 20, 2021

/covered


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276681: Additional malformed Javadoc inline tags in JDK source

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6486/head:pull/6486
$ git checkout pull/6486

Update a local copy of the PR:
$ git checkout pull/6486
$ git pull https://git.openjdk.java.net/jdk pull/6486/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6486

View PR using the GUI difftool:
$ git pr show -t 6486

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6486.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 20, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2021

Hi @tprinzing, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user tprinzing" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2021

@tprinzing The following labels will be automatically applied to this pull request:

  • client
  • compiler
  • core-libs
  • hotspot-jfr
  • net
  • security
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org security security-dev@openjdk.org client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org net net-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org labels Nov 20, 2021
@tprinzing tprinzing changed the title Jdk 8276681 : Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java JDK 8276681 : Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java Nov 20, 2021
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Nov 24, 2021
@tprinzing tprinzing changed the title JDK 8276681 : Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java JDK 8276681: Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java Dec 2, 2021
@tprinzing tprinzing changed the title JDK 8276681: Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java JDK-8276681: Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java Dec 2, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 2, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 2, 2021

@tprinzing This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276681: Additional malformed Javadoc inline tags in JDK source

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • b310f30: 8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread
  • 15345e3: 8276661: (fs) UserDefinedFileAttributeView no longer works with long path (win)
  • 652b5f8: 8276674: Malformed Javadoc inline tags in JDK source
  • e0f1fc7: 8277358: Accelerate CRC32-C
  • 73a9654: 8276806: Use Objects.checkFromIndexSize where possible in java.base
  • 30087cc: 8275342: Change nested classes in java.prefs to static nested classes
  • 669c90e: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError
  • 4f15be2: 8277965: Enclosing instance optimization affects serialization
  • 8f196a2: 8278037: Clean up PPC32 related code in C1
  • 8b042d1: 8257856: Make ClassFileVersionsTest.java robust to JDK version updates

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@LanceAndersen) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 2, 2021
@tprinzing tprinzing changed the title JDK-8276681: Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java JDK-8276681: Additional malformed Javadoc inline tags in JDK source Dec 2, 2021
@tprinzing
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 2, 2021
@openjdk
Copy link

openjdk bot commented Dec 2, 2021

@tprinzing
Your change (at version 8eaf05b) is now ready to be sponsored by a Committer.

@LanceAndersen
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 2, 2021

Going to push as commit b8ac0d2.
Since your change was applied there have been 10 commits pushed to the master branch:

  • b310f30: 8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread
  • 15345e3: 8276661: (fs) UserDefinedFileAttributeView no longer works with long path (win)
  • 652b5f8: 8276674: Malformed Javadoc inline tags in JDK source
  • e0f1fc7: 8277358: Accelerate CRC32-C
  • 73a9654: 8276806: Use Objects.checkFromIndexSize where possible in java.base
  • 30087cc: 8275342: Change nested classes in java.prefs to static nested classes
  • 669c90e: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError
  • 4f15be2: 8277965: Enclosing instance optimization affects serialization
  • 8f196a2: 8278037: Clean up PPC32 related code in C1
  • 8b042d1: 8257856: Make ClassFileVersionsTest.java robust to JDK version updates

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 2, 2021
@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 2, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 2, 2021
@openjdk
Copy link

openjdk bot commented Dec 2, 2021

@LanceAndersen @tprinzing Pushed as commit b8ac0d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated net net-dev@openjdk.org security security-dev@openjdk.org serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants