-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME" #6489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back dlong! A progress list of the required criteria for merging this PR into |
@dean-long To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
@dean-long This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks Aleksey. |
Thanks Stefan. |
/integrate |
Going to push as commit f62b81c.
Your commit was automatically rebased without conflicts. |
@dean-long Pushed as commit f62b81c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Relaxes exception message check so that both "Java heap space: failed reallocation of scalar replaced objects" and "Java heap space" are excepted. This is consistent with how other tests that check for "Java heap space" behave.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6489/head:pull/6489
$ git checkout pull/6489
Update a local copy of the PR:
$ git checkout pull/6489
$ git pull https://git.openjdk.java.net/jdk pull/6489/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6489
View PR using the GUI difftool:
$ git pr show -t 6489
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6489.diff