Skip to content

8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME" #6489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dean-long
Copy link
Member

@dean-long dean-long commented Nov 20, 2021

Relaxes exception message check so that both "Java heap space: failed reallocation of scalar replaced objects" and "Java heap space" are excepted. This is consistent with how other tests that check for "Java heap space" behave.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6489/head:pull/6489
$ git checkout pull/6489

Update a local copy of the PR:
$ git checkout pull/6489
$ git pull https://git.openjdk.java.net/jdk pull/6489/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6489

View PR using the GUI difftool:
$ git pr show -t 6489

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6489.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2021

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2021
@openjdk
Copy link

openjdk bot commented Nov 20, 2021

@dean-long To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Nov 22, 2021

@dean-long This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME"

Reviewed-by: shade, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 05a9a51: 8277423: ciReplay: hidden class with comment expected error
  • 1049aba: 8277576: ProblemList runtime/ErrorHandling/CreateCoredumpOnCrash.java on macosx-X64
  • 851a362: 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer
  • 6cf4cd1: 8273341: Update Siphash to version 1.0
  • e3911a8: 8277429: Conflicting jpackage static library name
  • 33e2a51: 8265795: vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java fails when running with JEP 416
  • 22f12ac: 8277522: Make formatting of null consistent in Elements
  • e529865: 8277239: SIGSEGV in vrshift_reg_maskedNode::emit
  • 8683de5: 8274685: Documentation suggests there are ArbitrarilyJumpableGenerator when none
  • 6b4fbae: 8273792: JumpableGenerator.rngs() documentation refers to wrong method
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/0a9e76c4f9d966015c19e87e3eb59ceb7489459f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 22, 2021
@dean-long
Copy link
Member Author

Thanks Aleksey.

@dean-long
Copy link
Member Author

Thanks Stefan.

@dean-long
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 22, 2021

Going to push as commit f62b81c.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 05a9a51: 8277423: ciReplay: hidden class with comment expected error
  • 1049aba: 8277576: ProblemList runtime/ErrorHandling/CreateCoredumpOnCrash.java on macosx-X64
  • 851a362: 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer
  • 6cf4cd1: 8273341: Update Siphash to version 1.0
  • e3911a8: 8277429: Conflicting jpackage static library name
  • 33e2a51: 8265795: vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java fails when running with JEP 416
  • 22f12ac: 8277522: Make formatting of null consistent in Elements
  • e529865: 8277239: SIGSEGV in vrshift_reg_maskedNode::emit
  • 8683de5: 8274685: Documentation suggests there are ArbitrarilyJumpableGenerator when none
  • 6b4fbae: 8273792: JumpableGenerator.rngs() documentation refers to wrong method
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/0a9e76c4f9d966015c19e87e3eb59ceb7489459f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2021
@openjdk
Copy link

openjdk bot commented Nov 22, 2021

@dean-long Pushed as commit f62b81c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dean-long dean-long deleted the 8273095 branch November 22, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants