Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277508: need to check has_predicated_vectors before calling scalable_predicate_reg_slots #6492

Closed
wants to merge 1 commit into from

Conversation

yadongw
Copy link
Contributor

@yadongw yadongw commented Nov 21, 2021

Hi, Team,
A separate set of predicate registers is not mandatory for an implementation of scalable vectors. It will cause a failure in some platform which supports scalable vectors without explicit predicated registers, like riscv. All code about RegVectMask should be covered by has_predicated_vectors here in Matcher::init_first_stack_mask().

Yadong


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277508: need to check has_predicated_vectors before calling scalable_predicate_reg_slots

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6492/head:pull/6492
$ git checkout pull/6492

Update a local copy of the PR:
$ git checkout pull/6492
$ git pull https://git.openjdk.java.net/jdk pull/6492/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6492

View PR using the GUI difftool:
$ git pr show -t 6492

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6492.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 21, 2021

👋 Welcome back yadongwang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 21, 2021

@yadongw The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Nov 21, 2021
@yadongw yadongw force-pushed the fix-init-predicated-reg-mask branch from 940c96c to b3171c2 Compare Nov 21, 2021
@yadongw yadongw changed the title missed to check has_predicated_vectors before calling scalable_predicate_reg_slots 8277508: missed to check has_predicated_vectors before calling scalable_predicate_reg_slots Nov 22, 2021
@yadongw yadongw changed the title 8277508: missed to check has_predicated_vectors before calling scalable_predicate_reg_slots 8277508: need to check has_predicated_vectors before calling scalable_predicate_reg_slots Nov 22, 2021
@openjdk openjdk bot added the rfr label Nov 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 22, 2021

Webrevs

@yadongw yadongw force-pushed the fix-init-predicated-reg-mask branch from b3171c2 to 5f54b7f Compare Nov 22, 2021
nsjian
nsjian approved these changes Nov 22, 2021
Copy link

@nsjian nsjian left a comment

Looks good to me.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

@yadongw This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277508: need to check has_predicated_vectors before calling scalable_predicate_reg_slots

Reviewed-by: njian, thartmann, ngasson

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

  • 7e54d06: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories
  • eb4d886: 8277504: Use String.stripTrailing instead of hand-crafted method in SwingUtilities2
  • 9879920: 8277825: Remove unused ReferenceProcessorPhaseTimes::_sub_phases_total_time_ms
  • f788834: 8277786: G1: Rename log2_card_region_per_heap_region used in G1CardSet
  • 3034ae8: 8277631: ZGC: CriticalMetaspaceAllocation asserts
  • f0136ec: 8275687: runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException
  • 21e302a: 8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find too_many string in output
  • a81e4fc: 8258117: jar tool sets the time stamp of module-info.class entries to the current time
  • 26472bd: 8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
  • b5841ba: 8277806: 4 tools/jar failures per platform after JDK-8272728
  • ... and 50 more: https://git.openjdk.java.net/jdk/compare/0a9e76c4f9d966015c19e87e3eb59ceb7489459f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian, @TobiHartmann, @nick-arm) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 23, 2021
@yadongw
Copy link
Contributor Author

@yadongw yadongw commented Nov 23, 2021

Thanks. Could I have another (R)eviewer?

@yadongw
Copy link
Contributor Author

@yadongw yadongw commented Nov 25, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2021

@yadongw
Your change (at version 5f54b7f) is now ready to be sponsored by a Committer.

Copy link
Member

@nick-arm nick-arm left a comment

Looks ok to me.

@RealFYang
Copy link
Member

@RealFYang RealFYang commented Nov 26, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2021

Going to push as commit 00a6238.
Since your change was applied there have been 61 commits pushed to the master branch:

  • 3383c0d: 8277659: [TESTBUG] Microbenchmark ThreadOnSpinWaitProducerConsumer.java hangs
  • 7e54d06: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories
  • eb4d886: 8277504: Use String.stripTrailing instead of hand-crafted method in SwingUtilities2
  • 9879920: 8277825: Remove unused ReferenceProcessorPhaseTimes::_sub_phases_total_time_ms
  • f788834: 8277786: G1: Rename log2_card_region_per_heap_region used in G1CardSet
  • 3034ae8: 8277631: ZGC: CriticalMetaspaceAllocation asserts
  • f0136ec: 8275687: runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException
  • 21e302a: 8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find too_many string in output
  • a81e4fc: 8258117: jar tool sets the time stamp of module-info.class entries to the current time
  • 26472bd: 8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
  • ... and 51 more: https://git.openjdk.java.net/jdk/compare/0a9e76c4f9d966015c19e87e3eb59ceb7489459f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2021

@RealFYang @yadongw Pushed as commit 00a6238.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
5 participants