JDK-8273146: Start of release updates for JDK 19 #6493

jddarcy · 2021-11-22T03:15:51Z

The time to get JDK 19 underway draws nigh, please review this usual set of start-of-release updates, including CSRs for the javac and javax.lang.model updates:

JDK-8277512: Add SourceVersion.RELEASE_19
https://bugs.openjdk.java.net/browse/JDK-8277512

JDK-8277514: Add source 19 and target 19 to javac
https://bugs.openjdk.java.net/browse/JDK-8277514

Clean local tier 1 test runs for langtools, jdk, and hotspot.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issues

JDK-8273146: Start of release updates for JDK 19
JDK-8277511: Add SourceVersion.RELEASE_19
JDK-8277513: Add source 19 and target 19 to javac

Reviewers

David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 5fe55cb
Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to 4da056a
Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to 4da056a
Iris Clark (@irisclark - Reviewer) ⚠️ Review applies to 4005b92
Mikael Vidstedt (@vidmik - Reviewer) ⚠️ Review applies to 4da056a
Magnus Ihse Bursie (@magicus - Reviewer) ⚠️ Review applies to 5fe55cb

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6493/head:pull/6493
$ git checkout pull/6493

Update a local copy of the PR:
$ git checkout pull/6493
$ git pull https://git.openjdk.java.net/jdk pull/6493/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6493

View PR using the GUI difftool:
$ git pr show -t 6493

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6493.diff

bridgekeeper · 2021-11-22T03:16:05Z

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-11-22T03:18:32Z

@jddarcy The following labels will be automatically applied to this pull request:

build
compiler
core-libs
hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-11-22T03:24:16Z

Webrevs

jddarcy · 2021-11-22T03:51:25Z

/issue add JDK-8277511

jddarcy · 2021-11-22T03:51:40Z

/issue add JDK-8277513

openjdk · 2021-11-22T03:52:43Z

@jddarcy
Adding additional issue to issue list: 8277511: Add SourceVersion.RELEASE_19.

openjdk · 2021-11-22T03:53:47Z

@jddarcy
Adding additional issue to issue list: 8277513: Add source 19 and target 19 to javac.

dholmes-ora

Hi Joe,

I looked at all the non-sym file changes. Only one potential issue spotted.

Thanks,
David

dholmes-ora · 2021-11-22T04:17:44Z

test/langtools/tools/javac/versions/Versions.java

@@ -87,7 +87,8 @@ public static void main(String... args) throws IOException {
        FIFTEEN(false,  "59.0", "15", Versions::checksrc15),
        SIXTEEN(false,  "60.0", "16", Versions::checksrc16),
        SEVENTEEN(false, "61.0", "17", Versions::checksrc17),
-        EIGHTEEN(false,  "62.0", "18", Versions::checksrc18);
+        EIGHTEEN(false,  "62.0", "18", Versions::checksrc18),
+        NINETEEN(false,  "63.0", "19", Versions::checksrc18);


checkSrc19?

jddarcy · 2021-11-22T04:26:31Z

Hi Joe,

I looked at all the non-sym file changes. Only one potential issue spotted.

Thanks, David

sigh Yep; cut and paste error -- corrected in next push. Well spotted!

Thanks David

dholmes-ora

Update looks good.

openjdk · 2021-11-22T04:34:09Z

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273146: Start of release updates for JDK 19
8277511: Add SourceVersion.RELEASE_19
8277513: Add source 19 and target 19 to javac

Reviewed-by: dholmes, alanb, erikj, iris, mikael, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

AlanBateman

It's not possible to manual review the sym files but everything else looks okay. I searched the test tree for any additional tests that might need updating but didn't spot any.

dholmes-ora

Update is good.

magicus

Build changes look good

jddarcy · 2021-12-09T05:31:06Z

/integrate defer

openjdk · 2021-12-09T05:31:29Z

@jddarcy Integration of this pull request has been deferred and may be completed by any project committer using the /integrate pull request command.

JesperIRL · 2021-12-09T16:48:05Z

/integrate

openjdk · 2021-12-09T17:02:58Z

Going to push as commit 09831e7.
Since your change was applied there have been 6 commits pushed to the master branch:

6dae52f: 8276985: AArch64: [vectorapi] Backend support of VectorMaskToLongNode
08aad85: 8211230: JFR: internal events
965ea8d: 8274298: JFR Thread Sampler thread must not acquire malloc lock after suspending a thread because of possible deadlock
84baea7: 8278433: Use snippets in jdk.incubator.foreign documentation
1ea766d: 8278419: JFR jcmd option contract "This value cannot be changed once JFR has been initialized" is not enforced
62a7f5d: 8254318: Remove .hgtags

Your commit was automatically rebased without conflicts.

openjdk · 2021-12-09T17:04:01Z

@JesperIRL Pushed as commit 09831e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

jddarcy added 2 commits Nov 21, 2021

JDK-8273146: Start of release updates for JDK 19

b34799b

Add --release 18 information. Good tier1 test results.

5052cd9

openjdk bot added the rfr Pull request is ready for review label Nov 22, 2021

openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Nov 22, 2021

dholmes-ora reviewed Nov 22, 2021

View changes

Respond to review feedback.

4da056a

dholmes-ora approved these changes Nov 22, 2021

View changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 22, 2021

AlanBateman approved these changes Nov 22, 2021

View changes

erikj79 approved these changes Nov 22, 2021

View changes

irisclark approved these changes Nov 22, 2021

View changes

vidmik approved these changes Nov 22, 2021

View changes

jddarcy added 3 commits Nov 23, 2021

Merge branch 'master' into JDK-8273146

a00adc0

Remove SharedSpaces options from VMDeprecatedOptions.java.

5fe55cb

Merge branch 'master' into JDK-8273146

2894796

dholmes-ora approved these changes Nov 24, 2021

View changes

magicus approved these changes Nov 24, 2021

View changes

Merge branch 'master' into JDK-8273146

5c36a2e

jddarcy added 16 commits Dec 4, 2021

Merge branch 'master' into JDK-8273146

f0c9c96

Merge branch 'master' into JDK-8273146

8847647

Merge branch 'master' into JDK-8273146

880ff1d

Merge branch 'master' into JDK-8273146

9f68398

Merge branch 'master' into JDK-8273146

0459078

Merge branch 'master' into JDK-8273146

5e0ac8e

Merge branch 'master' into JDK-8273146

6ded3cf

Fixed VMDeprecatedOptions.java for JDK 19.

2186306

Merge branch 'master' into JDK-8273146

1088d3a

Merge branch 'master' into JDK-8273146

7e422f8

Merge branch 'master' into JDK-8273146

8f863ac

Sync with symbol generation changes.

93bad14

Merge branch 'master' into JDK-8273146

8d49e82

Merge branch 'master' into JDK-8273146

3bc045b

Update symbol information for JDK 18 b27.

4005b92

Merge branch 'master' into JDK-8273146

795903f

irisclark approved these changes Dec 9, 2021

View changes

openjdk bot added the deferred label Dec 9, 2021

openjdk bot closed this Dec 9, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review deferred labels Dec 9, 2021

jddarcy deleted the JDK-8273146 branch Dec 9, 2021

JDK-8273146: Start of release updates for JDK 19 #6493

JDK-8273146: Start of release updates for JDK 19 #6493

jddarcy commented Nov 22, 2021 •

edited by openjdk bot

bridgekeeper bot commented Nov 22, 2021

openjdk bot commented Nov 22, 2021

mlbridge bot commented Nov 22, 2021 •

edited

jddarcy commented Nov 22, 2021

jddarcy commented Nov 22, 2021

openjdk bot commented Nov 22, 2021

openjdk bot commented Nov 22, 2021

dholmes-ora left a comment

dholmes-ora Nov 22, 2021

jddarcy commented Nov 22, 2021

dholmes-ora left a comment

openjdk bot commented Nov 22, 2021 •

edited

AlanBateman left a comment

dholmes-ora left a comment

magicus left a comment

jddarcy commented Dec 9, 2021

openjdk bot commented Dec 9, 2021

JesperIRL commented Dec 9, 2021

openjdk bot commented Dec 9, 2021

openjdk bot commented Dec 9, 2021

JDK-8273146: Start of release updates for JDK 19 #6493

JDK-8273146: Start of release updates for JDK 19 #6493

Conversation

jddarcy commented Nov 22, 2021 • edited by openjdk bot

Progress

Issues

Reviewers

Reviewing

bridgekeeper bot commented Nov 22, 2021

openjdk bot commented Nov 22, 2021

mlbridge bot commented Nov 22, 2021 • edited

Webrevs

jddarcy commented Nov 22, 2021

jddarcy commented Nov 22, 2021

openjdk bot commented Nov 22, 2021

openjdk bot commented Nov 22, 2021

dholmes-ora left a comment

Choose a reason for hiding this comment

dholmes-ora Nov 22, 2021

Choose a reason for hiding this comment

jddarcy commented Nov 22, 2021

dholmes-ora left a comment

Choose a reason for hiding this comment

openjdk bot commented Nov 22, 2021 • edited

AlanBateman left a comment

Choose a reason for hiding this comment

dholmes-ora left a comment

Choose a reason for hiding this comment

magicus left a comment

Choose a reason for hiding this comment

jddarcy commented Dec 9, 2021

openjdk bot commented Dec 9, 2021

JesperIRL commented Dec 9, 2021

openjdk bot commented Dec 9, 2021

openjdk bot commented Dec 9, 2021

jddarcy commented Nov 22, 2021 •

edited by openjdk bot

mlbridge bot commented Nov 22, 2021 •

edited

openjdk bot commented Nov 22, 2021 •

edited