New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8273146: Start of release updates for JDK 19 #6493
Conversation
|
@jddarcy The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
/issue add JDK-8277511 |
/issue add JDK-8277513 |
@jddarcy |
@jddarcy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Joe,
I looked at all the non-sym file changes. Only one potential issue spotted.
Thanks,
David
@@ -87,7 +87,8 @@ public static void main(String... args) throws IOException { | |||
FIFTEEN(false, "59.0", "15", Versions::checksrc15), | |||
SIXTEEN(false, "60.0", "16", Versions::checksrc16), | |||
SEVENTEEN(false, "61.0", "17", Versions::checksrc17), | |||
EIGHTEEN(false, "62.0", "18", Versions::checksrc18); | |||
EIGHTEEN(false, "62.0", "18", Versions::checksrc18), | |||
NINETEEN(false, "63.0", "19", Versions::checksrc18); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkSrc19?
sigh Yep; cut and paste error -- corrected in next push. Well spotted! Thanks David |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update looks good.
@jddarcy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not possible to manual review the sym files but everything else looks okay. I searched the test tree for any additional tests that might need updating but didn't spot any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build changes look good
/integrate defer |
@jddarcy Integration of this pull request has been deferred and may be completed by any project committer using the /integrate pull request command. |
/integrate |
Going to push as commit 09831e7.
Your commit was automatically rebased without conflicts. |
@JesperIRL Pushed as commit 09831e7. |
The time to get JDK 19 underway draws nigh, please review this usual set of start-of-release updates, including CSRs for the javac and javax.lang.model updates:
JDK-8277512: Add SourceVersion.RELEASE_19
https://bugs.openjdk.java.net/browse/JDK-8277512
JDK-8277514: Add source 19 and target 19 to javac
https://bugs.openjdk.java.net/browse/JDK-8277514
Clean local tier 1 test runs for langtools, jdk, and hotspot.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6493/head:pull/6493
$ git checkout pull/6493
Update a local copy of the PR:
$ git checkout pull/6493
$ git pull https://git.openjdk.java.net/jdk pull/6493/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6493
View PR using the GUI difftool:
$ git pr show -t 6493
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6493.diff