Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8273146: Start of release updates for JDK 19 #6493

Closed
wants to merge 29 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Nov 22, 2021

The time to get JDK 19 underway draws nigh, please review this usual set of start-of-release updates, including CSRs for the javac and javax.lang.model updates:

JDK-8277512: Add SourceVersion.RELEASE_19
https://bugs.openjdk.java.net/browse/JDK-8277512

JDK-8277514: Add source 19 and target 19 to javac
https://bugs.openjdk.java.net/browse/JDK-8277514

Clean local tier 1 test runs for langtools, jdk, and hotspot.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6493/head:pull/6493
$ git checkout pull/6493

Update a local copy of the PR:
$ git checkout pull/6493
$ git pull https://git.openjdk.java.net/jdk pull/6493/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6493

View PR using the GUI difftool:
$ git pr show -t 6493

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6493.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 22, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@jddarcy The following labels will be automatically applied to this pull request:

  • build
  • compiler
  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime build core-libs compiler labels Nov 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 22, 2021

@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Nov 22, 2021

/issue add JDK-8277511

@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Nov 22, 2021

/issue add JDK-8277513

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@jddarcy
Adding additional issue to issue list: 8277511: Add SourceVersion.RELEASE_19.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@jddarcy
Adding additional issue to issue list: 8277513: Add source 19 and target 19 to javac.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Joe,

I looked at all the non-sym file changes. Only one potential issue spotted.

Thanks,
David

@@ -87,7 +87,8 @@ public static void main(String... args) throws IOException {
FIFTEEN(false, "59.0", "15", Versions::checksrc15),
SIXTEEN(false, "60.0", "16", Versions::checksrc16),
SEVENTEEN(false, "61.0", "17", Versions::checksrc17),
EIGHTEEN(false, "62.0", "18", Versions::checksrc18);
EIGHTEEN(false, "62.0", "18", Versions::checksrc18),
NINETEEN(false, "63.0", "19", Versions::checksrc18);
Copy link
Member

@dholmes-ora dholmes-ora Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkSrc19?

@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Nov 22, 2021

Hi Joe,

I looked at all the non-sym file changes. Only one potential issue spotted.

Thanks, David

sigh Yep; cut and paste error -- corrected in next push. Well spotted!

Thanks David

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Update looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273146: Start of release updates for JDK 19
8277511: Add SourceVersion.RELEASE_19
8277513: Add source 19 and target 19 to javac

Reviewed-by: dholmes, alanb, erikj, iris, mikael, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 22, 2021
Copy link
Contributor

@AlanBateman AlanBateman left a comment

It's not possible to manual review the sym files but everything else looks okay. I searched the test tree for any additional tests that might need updating but didn't spot any.

vidmik
vidmik approved these changes Nov 22, 2021
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Update is good.

Copy link
Member

@magicus magicus left a comment

Build changes look good

@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Dec 9, 2021

/integrate defer

@openjdk openjdk bot added the deferred label Dec 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2021

@jddarcy Integration of this pull request has been deferred and may be completed by any project committer using the /integrate pull request command.

@JesperIRL
Copy link
Member

@JesperIRL JesperIRL commented Dec 9, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2021

Going to push as commit 09831e7.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 6dae52f: 8276985: AArch64: [vectorapi] Backend support of VectorMaskToLongNode
  • 08aad85: 8211230: JFR: internal events
  • 965ea8d: 8274298: JFR Thread Sampler thread must not acquire malloc lock after suspending a thread because of possible deadlock
  • 84baea7: 8278433: Use snippets in jdk.incubator.foreign documentation
  • 1ea766d: 8278419: JFR jcmd option contract "This value cannot be changed once JFR has been initialized" is not enforced
  • 62a7f5d: 8254318: Remove .hgtags

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr deferred labels Dec 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2021

@JesperIRL Pushed as commit 09831e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8273146 branch Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build compiler core-libs hotspot-runtime integrated
8 participants