-
Notifications
You must be signed in to change notification settings - Fork 6k
8277459: Add jwebserver tool #6497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back jboes! A progress list of the required criteria for merging this PR into |
|
Webrevs
|
This change adds a dedicated command-line tool for the Simple Web Server, to improve convenience and approachability. The new tool A man page for A new internal class JWebServer is added to be able to distinguish whether the server was launched via The new tests are copies of the existing command-line tests. |
src/jdk.httpserver/share/classes/com/sun/net/httpserver/SimpleFileServer.java
Show resolved
Hide resolved
src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/SimpleFileServerImpl.java
Outdated
Show resolved
Hide resolved
...k.httpserver/share/classes/sun/net/httpserver/simpleserver/resources/simpleserver.properties
Show resolved
Hide resolved
...k.httpserver/share/classes/sun/net/httpserver/simpleserver/resources/simpleserver.properties
Outdated
Show resolved
Hide resolved
src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/JWebServer.java
Outdated
Show resolved
Hide resolved
Build changes look good. |
* update module and package summary * add -version / --version option to usage * fix markdown formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@FrauBoes This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/Main.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build changes look good
/integrate |
Going to push as commit f505396.
Your commit was automatically rebased without conflicts. |
This change introduces jwebserver, a dedicated JDK tool for the Simple Web Server.
A description is provided in a follow-up comment.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6497/head:pull/6497
$ git checkout pull/6497
Update a local copy of the PR:
$ git checkout pull/6497
$ git pull https://git.openjdk.java.net/jdk pull/6497/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6497
View PR using the GUI difftool:
$ git pr show -t 6497
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6497.diff