New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277542: G1: Move G1CardSetFreePool and related classes to separate files #6499
Conversation
👋 Welcome back mli! A progress list of the required criteria for merging this PR into |
@Hamlin-Li The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using git diff --color-moved
to help me review the diff. However, the unnecessary change to
G1CardSetFreePool::free_list
(moving from hpp to cpp) introduced some friction. Please refrain from mixing mechanical and manual changes in the same commit; you can use a second commit in this PR for the manual tuning.
I see the same def is duplicated in two places:
in g1SegmentedArrayFreePool.hpp
:
typedef G1SegmentedArrayBuffer<mtGCCardSet> G1CardSetBuffer;
typedef G1SegmentedArrayBufferList<mtGCCardSet> G1CardSetBufferList;
and g1CardSetMemory.hpp
:
typedef G1SegmentedArrayBuffer<mtGCCardSet> G1CardSetBuffer;
typedef G1SegmentedArrayBufferList<mtGCCardSet> G1CardSetBufferList;
I believe such duplication is only transient -- later refactoring/renaming will fix this, so I am fine with the current PR.
@Hamlin-Li This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 34 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@albertnetymk Yes, such changes are only transient, they will be reverted in next PR. Thanks @tschatzl @albertnetymk for your reviews. /integrate |
Going to push as commit bb11c55.
Your commit was automatically rebased without conflicts. |
@Hamlin-Li Pushed as commit bb11c55. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
As G1CardSetFreePool and related classes are going to be reused outside of the remembered set, they should be factored out.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6499/head:pull/6499
$ git checkout pull/6499
Update a local copy of the PR:
$ git checkout pull/6499
$ git pull https://git.openjdk.java.net/jdk pull/6499/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6499
View PR using the GUI difftool:
$ git pr show -t 6499
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6499.diff