Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277556: Call ReferenceProcessorPhaseTimes::set_processing_is_mt once #6500

Closed

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Nov 22, 2021

Simple change of moving the call site of set_processing_is_mt.

Test: hotspot_gc


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277556: Call ReferenceProcessorPhaseTimes::set_processing_is_mt once

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6500/head:pull/6500
$ git checkout pull/6500

Update a local copy of the PR:
$ git checkout pull/6500
$ git pull https://git.openjdk.java.net/jdk pull/6500/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6500

View PR using the GUI difftool:
$ git pr show -t 6500

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6500.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 22, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 22, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277556: Call ReferenceProcessorPhaseTimes::set_processing_is_mt once

Reviewed-by: sjohanss, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 8683de5: 8274685: Documentation suggests there are ArbitrarilyJumpableGenerator when none
  • 6b4fbae: 8273792: JumpableGenerator.rngs() documentation refers to wrong method
  • d427c79: 8277428: G1: Move and inline G1STWIsAliveClosure::do_object_b
  • 32839ba: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"
  • 8051041: 8277534: Remove unused ReferenceProcessor::has_discovered_references

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 22, 2021
@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Nov 23, 2021

Thanks for the review.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

Going to push as commit 017df14.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 79350b9: 8276216: Negated character classes performance regression in Pattern
  • e3243ee: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND
  • 12f08ba: 8277507: Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures
  • bb11c55: 8277542: G1: Move G1CardSetFreePool and related classes to separate files
  • f62b81c: 8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME"
  • 05a9a51: 8277423: ciReplay: hidden class with comment expected error
  • 1049aba: 8277576: ProblemList runtime/ErrorHandling/CreateCoredumpOnCrash.java on macosx-X64
  • 851a362: 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer
  • 6cf4cd1: 8273341: Update Siphash to version 1.0
  • e3911a8: 8277429: Conflicting jpackage static library name
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/3f847fe89a088d6921107ca887a7a1bace871bd6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated and removed ready labels Nov 23, 2021
@albertnetymk albertnetymk deleted the set_processing_is_mt branch Nov 23, 2021
@openjdk openjdk bot removed the rfr label Nov 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

@albertnetymk Pushed as commit 017df14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants