Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274784: jshell: Garbled character was displayed by System.out.println(...) on Japanese Windows #6505

Closed
wants to merge 2 commits into from

Conversation

takiguc
Copy link

@takiguc takiguc commented Nov 22, 2021

JEP-400 was implemented by JDK18-b13.
After JDK18-b13, garbled character was displayed by following code on Japanese Windows' command prompt.

System.out.println("\u3042")

Japanese "A" should be display ed, but garbled character was displayed.
Also saved jshell command list did not work as expected if Japanese character was there.

Following issue has some information
8274544: Langtools command's usage were garbled on Japanese Windows #5771
#5771
This issue also happens on Linux ja_JP.eucjp locale.
RemoteExecutionControl.java change is required for this issue.

Also we cannot input Japanese character on Linux ja_JP.eucjp locale terminal.
AbstractTerminal.java change is required for this issue.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274784: jshell: Garbled character was displayed by System.out.println(...) on Japanese Windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6505/head:pull/6505
$ git checkout pull/6505

Update a local copy of the PR:
$ git checkout pull/6505
$ git pull https://git.openjdk.java.net/jdk pull/6505/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6505

View PR using the GUI difftool:
$ git pr show -t 6505

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6505.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2021

👋 Welcome back itakiguchi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2021
@openjdk
Copy link

openjdk bot commented Nov 22, 2021

@takiguc The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Nov 22, 2021
@takiguc
Copy link
Author

takiguc commented Nov 22, 2021

/label i18n

@openjdk openjdk bot added the i18n i18n-dev@openjdk.org label Nov 22, 2021
@openjdk
Copy link

openjdk bot commented Nov 22, 2021

@takiguc
The i18n label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 22, 2021

Webrevs

@takiguc
Copy link
Author

takiguc commented Nov 23, 2021

Thanks @naotoj .
I appreciate your suggestion.
I misread PrintStream.charset() spec.

naotoj
naotoj approved these changes Nov 24, 2021
Copy link
Member

@naotoj naotoj left a comment

Looks good to me.

@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@takiguc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274784: jshell: Garbled character was displayed by System.out.println(...) on Japanese Windows

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 91 new commits pushed to the master branch:

  • 951247c: 8235876: Misleading warning message in java source-file mode
  • 663e33d: 8272728: javac ignores any -J option in @argfiles silently
  • 0384739: 8276665: ObjectInputStream.GetField.get(name, object) should throw ClassNotFoundException
  • cf7adae: 8275320: NMT should perform buffer overrun checks
  • 96e3607: 8275063: Implementation of Foreign Function & Memory API (Second incubator)
  • 17e68ca: 8277042: add test for 8276036 to compiler/codecache
  • 8a8bc29: 8277562: Remove dead method c1 If::swap_sux
  • d085c2b: 8273328: Compiler implementation for Pattern Matching for switch (Second Preview)
  • 6d73460: 8277399: ZGC: Move worker thread logging out of gc+phase=debug
  • 712b875: 8277397: ZGC: Add JFR event for temporary latency measurements
  • ... and 81 more: https://git.openjdk.java.net/jdk/compare/db55f9272c0889f4ea4dee0f4aa3d9613fadb2f8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 24, 2021
@takiguc
Copy link
Author

takiguc commented Nov 29, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 29, 2021

Going to push as commit 8f9eb62.
Since your change was applied there have been 114 commits pushed to the master branch:

  • e9b36a8: 8276670: G1: Rename G1CardSetFreePool and related classes
  • b9eb532: 8276685: Malformed Javadoc inline tags in JDK source in /jdk/management/jfr/RecordingInfo.java
  • 40fef23: 8275908: Record null_check traps for calls and array_check traps in the interpreter
  • 3d810ad: 8277411: C2 fast_unlock intrinsic on AArch64 has unnecessary ownership check
  • ce0234b: 8277860: PPC: Remove duplicate info != NULL check
  • 040b2c5: 8277139: Improve code readability in PredecessorValidator (c1_IR.cpp)
  • 3e798dd: 8275330: C2: assert(n->is_Root() || n->is_Region() || n->is_Phi() || n->is_MachMerge() || def_block->dominates(block)) failed: uses must be dominated by definitions
  • 99e4bda: 8277417: C1 LIR instruction for load-klass
  • 00a6238: 8277508: need to check has_predicated_vectors before calling scalable_predicate_reg_slots
  • 3383c0d: 8277659: [TESTBUG] Microbenchmark ThreadOnSpinWaitProducerConsumer.java hangs
  • ... and 104 more: https://git.openjdk.java.net/jdk/compare/db55f9272c0889f4ea4dee0f4aa3d9613fadb2f8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 29, 2021
@openjdk
Copy link

openjdk bot commented Nov 29, 2021

@takiguc Pushed as commit 8f9eb62.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n i18n-dev@openjdk.org integrated Pull request has been integrated kulla kulla-dev@openjdk.org
2 participants