-
Notifications
You must be signed in to change notification settings - Fork 6.1k
JDK-8268582: javadoc throws NPE with --ignore-source-errors option #6506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into |
@hns This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 121 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 0dfb3a7.
Your commit was automatically rebased without conflicts. |
Please review a simple fix for a javadoc NPE when using the undocumented
--ignore-source-errors
option with an non-existing type.Note that this just fixes the particular error that occurs when looking for preview API use in invalid types. It is possible that other source errors trigger other errors in javadoc, but I don't think it is worth the time to go and actively look for them.
In particular, the NPE that is documented by the stack trace in the JBS issue was different from the one fixed here and does not occur anymore, and the one fixed here did not yet exist in JDK 11.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6506/head:pull/6506
$ git checkout pull/6506
Update a local copy of the PR:
$ git checkout pull/6506
$ git pull https://git.openjdk.java.net/jdk pull/6506/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6506
View PR using the GUI difftool:
$ git pr show -t 6506
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6506.diff