Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277576: ProblemList runtime/ErrorHandling/CreateCoredumpOnCrash.java on macosx-X64 #6507

Closed
wants to merge 3 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Nov 22, 2021

A few trivial ProblemListings:

8277576 ProblemList runtime/ErrorHandling/CreateCoredumpOnCrash.java on macosx-X64
8277577 ProblemList compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java on linux-aarch64
8277578 ProblemList applications/jcstress/acqrel.java on linux-aarch64


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8277576: ProblemList runtime/ErrorHandling/CreateCoredumpOnCrash.java on macosx-X64
  • JDK-8277577: ProblemList compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java on linux-aarch64
  • JDK-8277578: ProblemList applications/jcstress/acqrel.java on linux-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6507/head:pull/6507
$ git checkout pull/6507

Update a local copy of the PR:
$ git checkout pull/6507
$ git pull https://git.openjdk.java.net/jdk pull/6507/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6507

View PR using the GUI difftool:
$ git pr show -t 6507

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6507.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 22, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 22, 2021

/issue JDK-8277576
/issue JDK-8277577
/issue JDK-8277578

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 22, 2021

/label add hotspot-runtime
/label add hotspot-compiler
/label add hotspot-gc

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Nov 22, 2021
@openjdk openjdk bot changed the title Jdk 8277576 8277576: ProblemList runtime/ErrorHandling/CreateCoredumpOnCrash.java on macosx-X64 Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added the rfr label Nov 22, 2021
vidmik
vidmik approved these changes Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277576: ProblemList runtime/ErrorHandling/CreateCoredumpOnCrash.java on macosx-X64
8277577: ProblemList compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java on linux-aarch64
8277578: ProblemList applications/jcstress/acqrel.java on linux-aarch64

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 851a362: 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8277577: ProblemList compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java on linux-aarch64.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8277578: ProblemList applications/jcstress/acqrel.java on linux-aarch64.

@openjdk openjdk bot added the hotspot-runtime label Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 22, 2021

@vidmik - Thanks for the fast review!

/integrate

@openjdk openjdk bot added the hotspot-compiler label Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the hotspot-gc label Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@dcubed-ojdk
The hotspot-gc label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

Going to push as commit 1049aba.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 851a362: 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@dcubed-ojdk Pushed as commit 1049aba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 22, 2021

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8277576 branch Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-gc hotspot-runtime integrated
2 participants