Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277350: runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java times out #6510

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Nov 22, 2021

A (trivial?) fix to keep runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java
from timing out on macosx-X64 Mach5 test machines. Also removes the test from the
ProblemList.txt file.

Tested locally on my MBP-13 to verify that the test no longer creates core files.
Will also test with Mach5 Tier[135] to test for "timeouts in execution" task failures.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277350: runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java times out

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6510/head:pull/6510
$ git checkout pull/6510

Update a local copy of the PR:
$ git checkout pull/6510
$ git pull https://git.openjdk.java.net/jdk pull/6510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6510

View PR using the GUI difftool:
$ git pr show -t 6510

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6510.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 22, 2021
@openjdk
Copy link

openjdk bot commented Nov 22, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review November 22, 2021 20:55
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2021

Webrevs

Copy link
Member

@hseigel hseigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and trivial.
Thanks, Harold

@openjdk
Copy link

openjdk bot commented Nov 22, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277350: runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java times out

Reviewed-by: hseigel, dholmes, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • bb11c55: 8277542: G1: Move G1CardSetFreePool and related classes to separate files
  • f62b81c: 8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME"
  • 05a9a51: 8277423: ciReplay: hidden class with comment expected error

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 22, 2021
@dcubed-ojdk
Copy link
Member Author

@hseigel - Thanks for the fast review! I'm going to wait until I have Mach5 Tier[1-3]
test results just to have some level of assurance that I don't reintroduce a "timeouts
in execution" test task failure mode.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2 :)

@dcubed-ojdk
Copy link
Member Author

@dholmes-ora and @lmesnik - Thanks for the reviews!

@dcubed-ojdk
Copy link
Member Author

Mach5 Tier[13] testing had no failures. Mach5 Tier5 testing had
19 unrelated client test failures and one unrelated zero build failure.

So no sign of the "timeouts in execution" test task failure mode, but that's
just one set of jobs. Only more test runs will really tell the tale...

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2021

Going to push as commit e8acac2.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 8a44e09: 8268725: jshell does not support the --enable-native-access option
  • 7b67a49: 8261847: performance of java.lang.Record::toString should be improved
  • 38802ad: 8254108: ciReplay: Support incremental inlining
  • 64bdc84: 8277649: [BACKOUT] JDK-8277507 Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures
  • 5e7e2da: 8272042: java.util.ImmutableCollections$Map1 and MapN should not be @valuebased
  • f4dc03e: 8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper
  • 90f96fb: 8277441: CompileQueue::add fails with assert(_last->next() == __null) failed: not last
  • 66eaf65: 8277413: Remove unused local variables in jdk.hotspot.agent
  • 36b887a: 8277560: Remove WorkerDataArray::_is_serial
  • 017df14: 8277556: Call ReferenceProcessorPhaseTimes::set_processing_is_mt once
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/1049aba1fb65fd70bd723c80a84250512a68d653...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@dcubed-ojdk Pushed as commit e8acac2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8277350 branch November 23, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants