New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277350: runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java times out #6510
Conversation
/label add hotspot-runtime |
👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into |
@dcubed-ojdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and trivial.
Thanks, Harold
@dcubed-ojdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@hseigel - Thanks for the fast review! I'm going to wait until I have Mach5 Tier[1-3] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2 :)
@dholmes-ora and @lmesnik - Thanks for the reviews! |
Mach5 Tier[13] testing had no failures. Mach5 Tier5 testing had So no sign of the "timeouts in execution" test task failure mode, but that's /integrate |
Going to push as commit e8acac2.
Your commit was automatically rebased without conflicts. |
@dcubed-ojdk Pushed as commit e8acac2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A (trivial?) fix to keep runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java
from timing out on macosx-X64 Mach5 test machines. Also removes the test from the
ProblemList.txt file.
Tested locally on my MBP-13 to verify that the test no longer creates core files.
Will also test with Mach5 Tier[135] to test for "timeouts in execution" task failures.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6510/head:pull/6510
$ git checkout pull/6510
Update a local copy of the PR:
$ git checkout pull/6510
$ git pull https://git.openjdk.java.net/jdk pull/6510/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6510
View PR using the GUI difftool:
$ git pr show -t 6510
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6510.diff