Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277606: String(String) constructor could copy hashIsZero #6511

Closed

Conversation

JarvisCraft
Copy link
Contributor

@JarvisCraft JarvisCraft commented Nov 22, 2021

This is a trivial fix to make String(String) constructor copy the value of hashIsZero field.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277606: String(String) constructor could copy hashIsZero

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6511/head:pull/6511
$ git checkout pull/6511

Update a local copy of the PR:
$ git checkout pull/6511
$ git pull https://git.openjdk.java.net/jdk pull/6511/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6511

View PR using the GUI difftool:
$ git pr show -t 6511

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6511.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 22, 2021

👋 Welcome back JarvisCraft! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@JarvisCraft The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Nov 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 22, 2021

Webrevs

cl4es
cl4es approved these changes Nov 22, 2021
Copy link
Member

@cl4es cl4es left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

⚠️ @JarvisCraft the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout String-copy-zero-hashCode
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@JarvisCraft This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277606: String(String) constructor could copy hashIsZero

Reviewed-by: redestad, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

  • 5a4a9bb: 8278019: ProblemList java/awt/dnd/BadSerializationTest/BadSerializationTest.java on linux and windows
  • 15a6806: 8277434: tests fail with "assert(is_forwarded()) failed: only decode when actually forwarded"
  • 21d9ca6: 8274983: C1 optimizes the invocation of private interface methods
  • 98a9f03: 8277602: Deopt code does not extend the stack enough if the caller is an optimize entry blob
  • 9150840: 8277899: Parallel: Simplify PSVirtualSpace::initialize logic
  • 01cefc9: 8277977: Incorrect references to --enable-reproducible-builds in docs
  • 69f56a0: 8264485: build.tools.depend.Depend.toString(byte[]) creates malformed hex strings
  • fecf906: 8267928: Loop predicate gets inexact loop limit before PhaseIdealLoop::rc_predicate
  • a5f2a58: 8277846: Implement fast-path for ASCII-compatible CharsetEncoders on ppc64
  • ceae380: 8277843: [Vector API] scalar2vector generates incorrect type info for mask operations if Op_MaskAll is unavailable
  • ... and 77 more: https://git.openjdk.java.net/jdk/compare/05a9a51dbfc46eb52bc28f1f9a618c75ee2597e9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@cl4es, @RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 22, 2021
@JarvisCraft
Copy link
Contributor Author

@JarvisCraft JarvisCraft commented Nov 22, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@JarvisCraft
Your change (at version 6ebfa40) is now ready to be sponsored by a Committer.

@JarvisCraft
Copy link
Contributor Author

@JarvisCraft JarvisCraft commented Nov 30, 2021

Hi there, could anyone please sponsor this change if it is still applicable?

Thanks in advance!

@RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Nov 30, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

Going to push as commit e30e676.
Since your change was applied there have been 87 commits pushed to the master branch:

  • 5a4a9bb: 8278019: ProblemList java/awt/dnd/BadSerializationTest/BadSerializationTest.java on linux and windows
  • 15a6806: 8277434: tests fail with "assert(is_forwarded()) failed: only decode when actually forwarded"
  • 21d9ca6: 8274983: C1 optimizes the invocation of private interface methods
  • 98a9f03: 8277602: Deopt code does not extend the stack enough if the caller is an optimize entry blob
  • 9150840: 8277899: Parallel: Simplify PSVirtualSpace::initialize logic
  • 01cefc9: 8277977: Incorrect references to --enable-reproducible-builds in docs
  • 69f56a0: 8264485: build.tools.depend.Depend.toString(byte[]) creates malformed hex strings
  • fecf906: 8267928: Loop predicate gets inexact loop limit before PhaseIdealLoop::rc_predicate
  • a5f2a58: 8277846: Implement fast-path for ASCII-compatible CharsetEncoders on ppc64
  • ceae380: 8277843: [Vector API] scalar2vector generates incorrect type info for mask operations if Op_MaskAll is unavailable
  • ... and 77 more: https://git.openjdk.java.net/jdk/compare/05a9a51dbfc46eb52bc28f1f9a618c75ee2597e9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@RogerRiggs @JarvisCraft Pushed as commit e30e676.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JarvisCraft JarvisCraft deleted the String-copy-zero-hashCode branch Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants