Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277450: Record number of references into collection set during gc #6519

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Nov 23, 2021

Hi all,

could I have reviews for this change that adds logging for the number of heap roots found and pushed onto the task queues from the scanned cards? This can help with finding a good card size.

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277450: Record number of references into collection set during gc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6519/head:pull/6519
$ git checkout pull/6519

Update a local copy of the PR:
$ git checkout pull/6519
$ git pull https://git.openjdk.java.net/jdk pull/6519/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6519

View PR using the GUI difftool:
$ git pr show -t 6519

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6519.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 23, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 23, 2021

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277450: Record number of references into collection set during gc

Reviewed-by: kbarrett, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • 37de442: 8275241: Unused ArrayList is created in RequestEngine.addHooks
  • 72bacf8: 8276108: Wrong instruction generation in aarch64 backend
  • e3e5908: 8277847: Support toolGuide tag in class-level documentation
  • 9a3a9b1: 8277865: G1: Change integer division to floating point division
  • aed53ee: 8264838: IGV: enhance graph export functionality
  • 0c7a4b8: 8277842: IGV: Add jvms property to know where a node came from
  • c3a7f2f: 8277382: make c1 BlockMerger use IR::verify only when necessary
  • 8f9eb62: 8274784: jshell: Garbled character was displayed by System.out.println(...) on Japanese Windows
  • e9b36a8: 8276670: G1: Rename G1CardSetFreePool and related classes
  • b9eb532: 8276685: Malformed Javadoc inline tags in JDK source in /jdk/management/jfr/RecordingInfo.java
  • ... and 44 more: https://git.openjdk.java.net/jdk/compare/66eaf6526126eb27c18acc64c2bb0791142815c9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 25, 2021
Copy link
Member

@walulyai walulyai left a comment

lgtm!

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Nov 29, 2021

Thanks @walulyai @kimbarrett for your reviews
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

Going to push as commit e5676f8.
Since your change was applied there have been 55 commits pushed to the master branch:

  • 2622ab3: 8277928: Fix compilation on macosx-aarch64 after 8276108
  • 37de442: 8275241: Unused ArrayList is created in RequestEngine.addHooks
  • 72bacf8: 8276108: Wrong instruction generation in aarch64 backend
  • e3e5908: 8277847: Support toolGuide tag in class-level documentation
  • 9a3a9b1: 8277865: G1: Change integer division to floating point division
  • aed53ee: 8264838: IGV: enhance graph export functionality
  • 0c7a4b8: 8277842: IGV: Add jvms property to know where a node came from
  • c3a7f2f: 8277382: make c1 BlockMerger use IR::verify only when necessary
  • 8f9eb62: 8274784: jshell: Garbled character was displayed by System.out.println(...) on Japanese Windows
  • e9b36a8: 8276670: G1: Rename G1CardSetFreePool and related classes
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/66eaf6526126eb27c18acc64c2bb0791142815c9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@tschatzl Pushed as commit e5676f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8277450-log-found-roots branch Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants