Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8254748: Bad Copyright header format after JDK-8212218 #652

Closed
wants to merge 1 commit into from
Closed

JDK-8254748: Bad Copyright header format after JDK-8212218 #652

wants to merge 1 commit into from

Conversation

@tstuefe
Copy link
Member

@tstuefe tstuefe commented Oct 14, 2020

Please review this trivial copyright header fix. Thank you.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build (3/5 running) (2/2 running) (2/2 running)

Issue

  • JDK-8254748: Bad Copyright header format after JDK-8212218

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/652/head:pull/652
$ git checkout pull/652

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 14, 2020

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 14, 2020

Webrevs

Loading

Copy link
Contributor

@shipilev shipilev left a comment

Looks good and trivial.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254748: Bad Copyright header format after JDK-8212218

Reviewed-by: shade, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 14, 2020
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good and of course trivial.
Thanks for taking care of this promptly.
David

Loading

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Oct 14, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@tstuefe Pushed as commit ba140b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants