Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277649 [BACKOUT] JDK-8277507 Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures #6523

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Nov 23, 2021

This reverts commit 12f08ba.

The fix for JDK-8277507 is causing 38 failures per Tier2 job set.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277649: [BACKOUT] JDK-8277507 Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6523/head:pull/6523
$ git checkout pull/6523

Update a local copy of the PR:
$ git checkout pull/6523
$ git pull https://git.openjdk.java.net/jdk pull/6523/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6523

View PR using the GUI difftool:
$ git pr show -t 6523

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6523.diff

…kage tests to help diagonize recent intermittent failures"

This reverts commit 12f08ba.
@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Nov 23, 2021

/label add hotspot-runtime
/label add core-libs

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Nov 23, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277649: [BACKOUT] JDK-8277507 Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures

Reviewed-by: alanb, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Nov 23, 2021

@stefank and @AlanBateman - Thanks for the lightning fast reviews!

/integrate

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@dcubed-ojdk
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented Nov 23, 2021

Going to push as commit 64bdc84.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@dcubed-ojdk Pushed as commit 64bdc84.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Nov 23, 2021

Webrevs

@jaikiran
Copy link
Member

jaikiran commented Nov 23, 2021

Sorry, I should really have had run that original PR through tier2 from someone before merging it.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8277649 branch Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants