New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call #6526
Conversation
|
Webrevs
|
@rkennke This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 80 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
I couldn't see any benefits or regressions in specjvm. |
/integrate |
Going to push as commit 3d39f09.
Your commit was automatically rebased without conflicts. |
The runtime call in expanded Shenandoah LRB doesn't need to produce (and consume) raw memory state. I believe this is a left-over from when the LRB (or WB) allocated from TLABs, and would mess with TLAB pointers, when not ordered correctly. (Also, we used to require ordering with RBs back when we had them, but we already removed that memory dependency on -8 offset)
Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6526/head:pull/6526
$ git checkout pull/6526
Update a local copy of the PR:
$ git checkout pull/6526
$ git pull https://git.openjdk.java.net/jdk pull/6526/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6526
View PR using the GUI difftool:
$ git pr show -t 6526
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6526.diff