Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254695: G1: Next mark bitmap clear not cancelled after marking abort #653

Conversation

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Oct 14, 2020

Hi all,

can I have reviews for this change that fixes aborting the concurrent next bitmap clear if aborted?

The problems are that we can enter the clear loop with the marking already aborted, so

  • yielding does not return true any more (marking aborted while joining the STS) and we never abort in the loop if we join all conditions together
  • and G1 at least clears the first part(s) of the bitmap as the check is done afterwards

Testing: tier1-5; no more reproducable crashes with other changes (JDK-8253600)

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254695: G1: Next mark bitmap clear not cancelled after marking abort

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/653/head:pull/653
$ git checkout pull/653

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 14, 2020

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Oct 14, 2020
@tschatzl tschatzl marked this pull request as ready for review Oct 15, 2020
@openjdk openjdk bot added the rfr label Oct 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 15, 2020

Webrevs

Loading

Copy link
Member

@walulyai walulyai left a comment

lgtm.

Loading

Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2020

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254695: G1: Next mark bitmap clear not cancelled after marking abort

Reviewed-by: iwalulya, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

  • 3c2f5e0: 8254674: G1: Improve root location reference to dead obj verification message
  • abe5137: 8254719: ZGC: Clean up includes
  • 60159cf: 8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size
  • 9359ff0: 8252221: Use multiple workers for Parallel GC pre-touching
  • f44fc6d: 8254734: "dead loop detected" assert failure with patch from 8223051
  • 7f73474: 8254773: Remove unimplemented ciReplay::is_loaded(Klass* klass)
  • 167c192: 8254771: Remove unimplemented ciSignature::get_all_klasses
  • 81a8ff1: 8254769: Remove unimplemented BCEscapeAnalyzer::{add_dependence, propagate_dependencies}
  • 7e5eb49: 8253402: Convert vmSymbols::SID to enum class
  • 038f58d: 8226236: [TESTBUG] win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails
  • ... and 37 more: https://git.openjdk.java.net/jdk/compare/90de2894e90c0808ec98857bcd562897d14e2ffb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 15, 2020
@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Oct 15, 2020

Thanks @kstefanj @walulyai for your reviews.

Loading

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Oct 16, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 16, 2020
@openjdk openjdk bot added integrated and removed ready labels Oct 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@tschatzl Since your change was applied there have been 57 commits pushed to the master branch:

  • 34583eb: 8254161: Prevent instantiation of EnumSet subclasses through deserialization
  • 3d23bd8: 8254814: [Vector API] Fix an AVX512 crash after JDK-8223347
  • 7c0d417: 8251535: Partial peeling at unsigned test adds incorrect loop exit check
  • 5145bed: 8254125: Assertion in cppVtables.cpp during builds on 32bit Windows
  • bdda205: 8254369: Node::disconnect_inputs may skip precedences
  • 96bb6e7: 8251325: Miss 'L' for long value in if statement
  • 546620b: 8254192: ExtraSharedClassListFile contains extra white space at end of line
  • f3ce45f: 8254799: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryError.java fails with release VMs
  • cda22e3: 8254811: JDK-8254158 broke ppc64, s390 builds
  • 8ef88e5: 8249878: jfr_emergency_dump has secondary crashes
  • ... and 47 more: https://git.openjdk.java.net/jdk/compare/90de2894e90c0808ec98857bcd562897d14e2ffb...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1742c44.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@openjdk openjdk bot removed the rfr label Oct 16, 2020
@tschatzl tschatzl deleted the 8254695-next-bitmap-clear-not-cancelled branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants