8277753: Long*VectorTests.java fail with "bad AD file" on x86_32 after JDK-8276162

[DamonFool]

Hi all,

The following vector api tests fail with "bad AD file" on x86_32.

jdk/incubator/vector/Long128VectorTests.java
jdk/incubator/vector/Long256VectorTests.java
jdk/incubator/vector/Long512VectorTests.java
jdk/incubator/vector/LongMaxVectorTests.java
jdk/incubator/vector/Long64VectorTests.java

The failure reason is that several unsigned long comparison instructs are missing for x86_32.
The fix just added the missing instructs rules.

Testing:

• tier1 ~ tier3 on linux/x86_32, no regression.

Thanks.
Best regards,
Jie

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8277753: Long*VectorTests.java fail with "bad AD file" on x86_32 after JDK-8276162

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6533/head:pull/6533
$ git checkout pull/6533

Update a local copy of the PR:
$ git checkout pull/6533
$ git pull https://git.openjdk.java.net/jdk pull/6533/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6533

View PR using the GUI difftool:
$ git pr show -t 6533

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6533.diff

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (01844028)

[vnkozlov]

@DamonFool In PR description please describe what was the problem.
Yes, I see from changes that 32-bit .ad file was missing instruction definitions. But it should be said in description.

And say about testing you did.

[vnkozlov]

Good.

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277753: Long*VectorTests.java fail with "bad AD file" on x86_32 after JDK-8276162

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

• b79554b: 8278130: Failure in jdk/javadoc/tool/CheckManPageOptions.java after JDK-8274639
• ea905bd: 8277924: Small tweaks to foreign function and memory API
• e002bfe: 8278049: G1: add precondition to set_remainder_to_point_to_start
• 16cfbc4: 8278071: typos in MemorySegment::set, MemorySegment::setAtIndex javadoc
• 84ca14d: 8277194: applications/runthese/RunThese30M.java crashes with jfrSymbolTable.cpp:305 assert(_instance != null)
• 103da8f: 8274639: Provide a way to disable warnings for cross-modular links
• 088b244: 8251216: Implement MD5 intrinsics on AArch64
• a093cdd: 8276657: XSLT compiler tries to define a class with empty name
• 8198807: 8266435: WBMPImageReader.read() should not truncate the input stream
• b226ab9: 8276141: XPathFactory set/getProperty method
• ... and 92 more: https://git.openjdk.java.net/jdk/compare/6d734604a38447d81df36f4d4ca57ce71bd570af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonFool]

@DamonFool In PR description please describe what was the problem. Yes, I see from changes that 32-bit .ad file was missing instruction definitions. But it should be said in description.

And say about testing you did.

Thanks @vnkozlov .

Got it.
Will do it next time.

Testing:

• tier1 ~ tier3 on linux/x86_32, no regression

[TobiHartmann]

Looks good.

[DamonFool]

Looks good.

Thanks @TobiHartmann .
/integrate

[openjdk]

Going to push as commit 65960f7.
Since your change was applied there have been 106 commits pushed to the master branch:

• 3889af3: 8277906: Incorrect type for IV phi of long counted loops after CCP
• d2b16c8: 8276126: Dump time class transformation causes heap objects of non-boot classes to be archived
• 7696897: 8276837: [macos]: Error when signing the additional launcher
• 3d98ec1: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions
• b79554b: 8278130: Failure in jdk/javadoc/tool/CheckManPageOptions.java after JDK-8274639
• ea905bd: 8277924: Small tweaks to foreign function and memory API
• e002bfe: 8278049: G1: add precondition to set_remainder_to_point_to_start
• 16cfbc4: 8278071: typos in MemorySegment::set, MemorySegment::setAtIndex javadoc
• 84ca14d: 8277194: applications/runthese/RunThese30M.java crashes with jfrSymbolTable.cpp:305 assert(_instance != null)
• 103da8f: 8274639: Provide a way to disable warnings for cross-modular links
• ... and 96 more: https://git.openjdk.java.net/jdk/compare/6d734604a38447d81df36f4d4ca57ce71bd570af...master

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool Pushed as commit 65960f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.