Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277786: G1: Rename log2_card_region_per_heap_region used in G1CardSet #6539

Closed

Conversation

walulyai
Copy link
Member

@walulyai walulyai commented Nov 24, 2021

Hi all,

Please review this small change to rename log2_card_region_per_heap_region to log2_card_regions_per_heap_region in order to improve readability.

//


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277786: G1: Rename log2_card_region_per_heap_region used in G1CardSet

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6539/head:pull/6539
$ git checkout pull/6539

Update a local copy of the PR:
$ git checkout pull/6539
$ git pull https://git.openjdk.java.net/jdk pull/6539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6539

View PR using the GUI difftool:
$ git pr show -t 6539

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6539.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 24, 2021

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 24, 2021

@walulyai The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 24, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 24, 2021

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277786: G1: Rename log2_card_region_per_heap_region used in G1CardSet

Reviewed-by: ayang, tschatzl, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

  • 26472bd: 8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
  • b5841ba: 8277806: 4 tools/jar failures per platform after JDK-8272728
  • e785f69: 8276124: Provide snippet support for properties files
  • 96fe1d0: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"
  • 077b2de: 8274161: Cleanup redundant casts in jdk.compiler
  • 951247c: 8235876: Misleading warning message in java source-file mode
  • 663e33d: 8272728: javac ignores any -J option in @argfiles silently
  • 0384739: 8276665: ObjectInputStream.GetField.get(name, object) should throw ClassNotFoundException
  • cf7adae: 8275320: NMT should perform buffer overrun checks
  • 96e3607: 8275063: Implementation of Foreign Function & Memory API (Second incubator)
  • ... and 36 more: https://git.openjdk.java.net/jdk/compare/d427c79d3bd6c80b67c10d15a461f13ae7e0f84b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 24, 2021
Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

@walulyai
Copy link
Member Author

@walulyai walulyai commented Nov 25, 2021

Thanks for the reviews!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2021

Going to push as commit f788834.
Since your change was applied there have been 50 commits pushed to the master branch:

  • 3034ae8: 8277631: ZGC: CriticalMetaspaceAllocation asserts
  • f0136ec: 8275687: runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException
  • 21e302a: 8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find too_many string in output
  • a81e4fc: 8258117: jar tool sets the time stamp of module-info.class entries to the current time
  • 26472bd: 8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
  • b5841ba: 8277806: 4 tools/jar failures per platform after JDK-8272728
  • e785f69: 8276124: Provide snippet support for properties files
  • 96fe1d0: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"
  • 077b2de: 8274161: Cleanup redundant casts in jdk.compiler
  • 951247c: 8235876: Misleading warning message in java source-file mode
  • ... and 40 more: https://git.openjdk.java.net/jdk/compare/d427c79d3bd6c80b67c10d15a461f13ae7e0f84b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2021

@walulyai Pushed as commit f788834.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
4 participants