Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254761: Wrong intrinsic annotation used for StringLatin1.indexOfChar #654

Closed
wants to merge 4 commits into from

Conversation

@cl4es
Copy link
Member

@cl4es cl4es commented Oct 14, 2020

Wrong intrinsic name used, causing a build breakage


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build (5/5 running) (2/2 running) (2/2 running)

Issue

  • JDK-8254761: Wrong intrinsic annotation used for StringLatin1.indexOfChar

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/654/head:pull/654
$ git checkout pull/654

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 14, 2020

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

⚠️ @cl4es This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

Loading

@openjdk openjdk bot added the rfr label Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@cl4es The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254761: Wrong intrinsic annotation used for StringLatin1.indexOfChar

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 14, 2020
@cl4es
Copy link
Member Author

@cl4es cl4es commented Oct 14, 2020

Thanks for reviewing, @AlanBateman

Since builds are broken and I've verified a local build I'll go ahead and integrate without waiting for automated testing to complete.

/integrate

Loading

@openjdk openjdk bot closed this Oct 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@cl4es Pushed as commit a6a3813.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 14, 2020

Webrevs

Loading

@cl4es cl4es deleted the intrinsic branch Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants