-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8275908: Record null_check traps for calls and array_check traps in the interpreter #6541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back simonis! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, it looks good to me! But would be good to get a second review for it.
Nice test!
test/hotspot/jtreg/compiler/exceptions/OptimizeImplicitExceptions.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! Looks good to me besides what was already said.
…ava test. Includes minor fixes requested by Martin and Christian
@TheRealMDoerr, @chhagedorn thanks a lot for the quick reviews. I hope I could address all your concerns and suggestions with my latest push. @chhagedorn: I'm especially happy that you like the tests. As all too often the effort for a good test is much higher than for the fix itself :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes, they look good to me!
@chhagedorn: I'm especially happy that you like the tests. As all too often the effort for a good test is much higher than for the fix itself :)
Yes, I couldn't agree more to that. It's sometimes underestimated how much time that is needed to come up with a good test. So, I always appreciate the extra effort :)
@simonis This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks for the approval @chhagedorn . I found that the new The fix is trivial and I hope your approval is also valid for the latest version :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, non-JVMCI platforms need this fix (also PPC and s390). LGTM, now. We'll retest it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Looks good.
/integrate |
Thanks @chhagedorn, @TheRealMDoerr ! |
Going to push as commit 40fef23.
Your commit was automatically rebased without conflicts. |
The new tests are not written correctly and are causing failures in our tier3 CI runs. If you set an explicit GC on the @run line then you have to ensure no GC option is passed in when running jtreg, else you get two GC's requested and the test fails to run. |
null_checks
occurring at invoke bytecodes are currently not recorded by the profiler. This leads to unnecessary uncommon traps, deoptimizations and recompilations for exceptions which already occurred before the compilation (i.e. are "hot"). This change fixes the problem in the interpreter.array_checks
are currently recorded asclass_checks
in the interpreter and therefore not recognized by the compiler. This again leads to uncommon traps, deoptimizations and recompilations. This change unifies the handling ofarray_checks
in the interpreter and compiler and prevents unnecessary recompilation.The test is a stripped down version of a test which was developed for JDK-8273563: Improve performance of implicit exceptions with -XX:-OmitStackTraceInFastThrow (still under review). It introduces an extension to the Whitebox API to expose the decompile, deopt and trap counters which is also required for testing JDK-8273563. I think (and hope) it will also be helpful for others in the future.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6541/head:pull/6541
$ git checkout pull/6541
Update a local copy of the PR:
$ git checkout pull/6541
$ git pull https://git.openjdk.java.net/jdk pull/6541/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6541
View PR using the GUI difftool:
$ git pr show -t 6541
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6541.diff